Repository navigation
The pf-notification-drawer could use a built-in dismiss action #421
Description
Using the "bell" in the top nav makes sense for opening a notification drawer, but seems a bit odd to also use as the closing action. I'm curious if a "dismiss" action could be added at the top near the << icon, or provide a footer-include attribute (not notification-footer, but one for the drawer itself) that would allow for a location to place a button to hook up a "dismiss" to toggle the hideDrawer attrib.
Metadata
Metadata
Assignees
Labels
No labels
Activity
jeff-phillips-18 commentedon Feb 17, 2017
This is more of a Patternfly design pattern question. I agree with you though, I have often found myself looking for a close button.
@LHinson Could this be brought up in a patternfly design discussion?
benjaminapetersen commentedon Feb 17, 2017
Yup, would be great to iron that one out in a generic way that could be consistent across products. Its like a natural impulse to play with the open/close immediately, so not being certain about the location of the close button is a little unsettling.
benjaminapetersen commentedon Feb 21, 2017
@LHinson or anyone who may know, is the notification drawer used on any other RH products w/a solution for this button already implemented? Would be interesting to see as we are integrating the drawer this sprint in openshift.