Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 747292e. Configure here.
|
Hi @atyrode, thanks for this, and sorry it sat for a bit. The opt-in resolver is a small, clean way to let hosts restyle cut-away walls without forking the wall kind. One thing to sort out before it can go in: Bugbot's finding on |
747292e to
b773bdf
Compare
|
Yes, thanks for the review. Rebased on
Locally: |

WallCutoutalready accepts amaterialResolver, butWallSystemshard-wiresgetCurtainAwareWallMaterials, so a host cannot restyle cut-away walls without forking the wall kind (plugins cannot re-registerwall).This adds
setWallMaterialsResolver(resolver | null), read byWallSystemsthroughuseSyncExternalStore(nullrestores the default), and exportsgetCurtainAwareWallMaterialsso a host can wrap the default and replace one variant — for example a low stub in place of the translucent film for cut walls.No behaviour change by default.
bun run check-types --filter=@pascal-app/nodes: passesNote
Low Risk
Optional host hook with default unchanged; batch re-sew on resolver change is covered by a new test and mirrors existing appearance invalidation.
Overview
Hosts can now override how WallCutout picks wall material sets (visible, cut-away, translucent, delete) without forking the built-in wall kind.
setWallMaterialsResolver(resolver | null)swaps the resolver globally (nullrestoresgetCurtainAwareWallMaterials), withgetCurtainAwareWallMaterialsexported so hosts can wrap the default and tweak one variant (e.g. cut-away).WallSystems subscribes via
useSyncExternalStoreand passes the active resolver intoWallCutoutinstead of hard-wiring the curtain-aware helper. Wall batch merging treats resolver changes like other appearance inputs, so merged floor meshes re-sew after a swap instead of keeping stale materials. Default behavior is unchanged when no host override is set.Reviewed by Cursor Bugbot for commit b773bdf. Bugbot is set up for automated code reviews on this repo. Configure here.