Skip to content

build: guard missing local.properties, empty releasePath, and add signing fallback - #369

Open
rspier wants to merge 1 commit into
pachi81:vNextfrom
rspier:build-signing-and-releasepath
Open

rspier wants to merge 1 commit into
pachi81:vNextfrom
rspier:build-signing-and-releasepath

Conversation

@rspier

@rspier rspier commented Oct 2, 2026

Copy link
Copy Markdown

Mostly handle a bunch of edge cases.

  • Guard root properties loading against missing local.properties.
  • Guard APK and AAB copy tasks in mobile and wear against empty releasePath.
  • Add releaseSigning fallback across auto, mobile, and wear to use debug signing when release keystore is absen

…ning fallback

- Guard root properties loading against missing local.properties.
- Guard APK and AAB copy tasks in mobile and wear against empty releasePath.
- Add releaseSigning fallback across auto, mobile, and wear to use debug signing when release keystore is absent.
@pachi81

pachi81 commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Makes sense, but normally everyone can create its own local.properties.
But this way it is much easier.
Thank you!

But I will not merge before I have checked it and the current release version is published.

@pachi81
pachi81 changed the base branch from master to vNext October 3, 2026 08:44

@pachi81 pachi81 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common path is missing.
It does not work, yet...

@rspier

rspier commented Oct 25, 2026

Copy link
Copy Markdown
Author

What failure are you getting? I'm getting build failures on vNext and master today even without my changes, which makes me suspect something is wrong with my environment. (But I do remember it building when I sent this.)

@rspier

rspier commented Oct 25, 2026

Copy link
Copy Markdown
Author

Addendum: ./gradlew assembleDebug test is fine. I'm getting what seem to be preexisting failures on ./gradlew build.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants