Repository navigation
Conversation
cpanato
requested review from
justaugustus and
spencerschrock
and removed request for
a team
October 26, 2026 18:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5367 +/- ##
===========================================
+ Coverage 66.80% 78.37% +11.56%
===========================================
Files 230 251 +21
Lines 16602 14286 -2316
===========================================
+ Hits 11091 11196 +105
+ Misses 4808 3089 -1719
+ Partials 703 1 -702 🚀 New features to boost your workflow:
|
justaugustus
marked this pull request as draft
October 28, 2026 04:46
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
force-pushed
the
fix/license-github-directory
branch
from
October 28, 2026 10:18
f14208c to
dd81368
Compare
cpanato
marked this pull request as ready for review
October 28, 2026 10:18
Member
Author
|
ready for review @justaugustus |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: the License check's file search rejects
.github/LICENSE, so a repository whose license is stored there can be reported as having no license.What is the current behavior?
When the hosting API does not return a license, the filename heuristic only recognizes licenses at the repository root or within a root license directory. For example, moving
LICENSEto.github/LICENSEmakes it undetectable by this fallback.What is the new behavior (if this is a feature change)?
Recognize the existing license filename formats under
.github/as well, preserving the full path and SPDX identifier in findings. Continue rejecting license files in unrelated directories such asvendor/,docs/, and.github/workflows/.Update the documentation and describe the existing scoring policy as nine points for a detected license plus one for an FSF or OSI approved license.
Which issue(s) this PR fixes
Fixes #5068
Special notes for your reviewer
Validation:
-race. The new.github/cases failed before the fix.checks/evaluation,probes/hasLicenseFile, andprobes/hasFSFOrOSIApprovedLicensepass.git diff --checkpass.golangci-lint run -c .golangci.yml --new-from-rev=HEAD ./checks/raw/...reported zero issues before committing.The full
checks/rawsuite fails inTestMixedPinningand twoTestCollectDockerfilePinningcases because Docker image remediations are missing. These failures also reproduce using the originallicense.gothrough a Go overlay.Does this PR introduce a user-facing change?