Skip to content

trusted-execution-clusters: Bump to OCP 5.0 - #88288

Draft
Jakob-Naucke wants to merge 3 commits into
openshift:mainfrom
Jakob-Naucke:trusted-execution-clusters-go1.26
Draft

Jakob-Naucke wants to merge 3 commits into
openshift:mainfrom
Jakob-Naucke:trusted-execution-clusters-go1.26

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

and golang 1.26

Summary by CodeRabbit

  • Updates the trusted-execution-clusters operator CI to use OpenShift 5.0 images and the Go 1.26 build root.
  • Updates the Azure CI configuration to use the OpenShift 5.0 CLI image and sets the release candidate version to 5.0.
  • Extends the Azure integration-test timeout to three hours and increases test execution from two threads to three.

and golang 1.26

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2026
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

The default and Azure operator CI configurations now use updated build-root images. The Azure configuration also updates its CLI image stream and release candidate version. Its integration test has a longer timeout and uses more threads.

Changes

Operator CI configuration

Layer / File(s) Summary
Update CI image and release versions
ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml, ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml
Both configurations use the rhel-9-golang-1.26-openshift-5.0 build-root image. The Azure configuration updates its CLI image stream and release candidate version from 4.22 to 5.0.
Update Azure integration test settings
ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml, ci-operator/step-registry/trusted-execution-clusters/ref/azure-integration-test/trusted-execution-clusters-ref-azure-integration-test-commands.sh
The Azure integration-test step adds a 3h0m0s timeout. The test command increases INTEGRATION_TEST_THREADS from 2 to 3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 3a70e

The configuration moves CI to OpenShift 5.0 and allows longer, more parallel Azure tests. No merge-blocking risk is established; normal CI validation remains appropriate.

Pre-merge checks: Passed 15
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names Passed The pull request changes CI image versions, release metadata, timeout, and INTEGRATION_TEST_THREADS; it does not add or modify any Ginkgo test title. The authoritative diff contains no changes to `I…
Test Structure And Quality Passed No Ginkgo test code was added or modified. The PR changes CI image and release settings, adds a 3-hour job timeout, and changes INTEGRATION_TEST_THREADS from 2 to 3. No new It, Eventually, Consistentl…
Microshift Test Compatibility Passed PASS: The pull request adds no Ginkgo e2e tests. The reviewed diff changes CI image versions, release metadata, timeout, presubmit labels, and integration-test thread count only. Therefore, the MicroS…
Single Node Openshift (Sno) Test Compatibility Passed The pull request adds no Ginkgo e2e tests. The authoritative diff changes only CI configuration, a generated Prow job definition, and an integration-test shell command. Therefore, no new test can intr…
Topology-Aware Scheduling Compatibility Passed PASS: The pull request changes only CI configuration, a generated presubmit job release label, and integration-test settings. The diff adds no deployment manifest, operator/controller code, replica lo…
Ote Binary Stdout Contract Passed The pull request changes only CI configuration, generated job metadata, a timeout, and INTEGRATION_TEST_THREADS. It does not modify OTE binary process-level code or add stdout writes in main(), init()…
Ipv6 And Disconnected Network Test Compatibility Passed PASS. The PR adds no Ginkgo e2e tests and introduces no new IPv4 assumptions or external connectivity. The changed files update CI image versions, timeout, job metadata, and integration-test paralleli…
No-Weak-Crypto Passed The pull request changes only CI configuration and test execution: image/release versions, job labels, a 3-hour timeout, and integration-test threads. The added lines contain no MD5, SHA1, DES, RC4, 3…
Container-Privileges Passed PASS. The pull request changes image tags, release labels, test timeout, and integration-test thread count. The four changed files contain no privileged: true, hostPID, hostNetwork, hostIPC, `…
No-Sensitive-Data-In-Logs Passed The pull request adds no logging statements or log formatting. The changed lines only update image and release versions, set a 3-hour timeout, increase integration-test threads, and update generated j…
Title check Passed The title clearly and concisely describes the primary change: upgrading trusted-execution-clusters to OpenShift 5.0.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

The pull request changes CI image versions, release metadata, timeout, and INTEGRATION_TEST_THREADS; it does not add or modify any Ginkgo test title. The authoritative diff contains no changes to It(), Describe(), Context(), When(), or legacy metadata test-name tokens. Therefore, this check has no pull-request-caused naming violation.

Full details: Test Structure And Quality

Explanation

No Ginkgo test code was added or modified. The PR changes CI image and release settings, adds a 3-hour job timeout, and changes INTEGRATION_TEST_THREADS from 2 to 3. No new It, Eventually, Consistently, assertion, setup, or cleanup code is present, so none of the stated test-quality failure conditions are introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The reviewed diff changes CI image versions, release metadata, timeout, presubmit labels, and integration-test thread count only. Therefore, the MicroShift test compatibility conditions do not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request adds no Ginkgo e2e tests. The authoritative diff changes only CI configuration, a generated Prow job definition, and an integration-test shell command. Therefore, no new test can introduce an SNO multi-node assumption.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only CI configuration, a generated presubmit job release label, and integration-test settings. The diff adds no deployment manifest, operator/controller code, replica logic, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore it introduces no topology-sensitive scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes only CI configuration, generated job metadata, a timeout, and INTEGRATION_TEST_THREADS. It does not modify OTE binary process-level code or add stdout writes in main(), init(), TestMain(), suite setup, or top-level initializers.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS. The PR adds no Ginkgo e2e tests and introduces no new IPv4 assumptions or external connectivity. The changed files update CI image versions, timeout, job metadata, and integration-test parallelism. Existing external downloads in the integration script are unchanged.

Full details: No-Weak-Crypto

Explanation

The pull request changes only CI configuration and test execution: image/release versions, job labels, a 3-hour timeout, and integration-test threads. The added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparisons.

Full details: Container-Privileges

Explanation

PASS. The pull request changes image tags, release labels, test timeout, and integration-test thread count. The four changed files contain no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security-context declarations.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request adds no logging statements or log formatting. The changed lines only update image and release versions, set a 3-hour timeout, increase integration-test threads, and update generated job labels. No added line contains password, token, API key, PII, session ID, hostname, or customer-data handling.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: openshift/release
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 8b4cdb0
  • Layers: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0b8dda9d-1fd7-4675-9b8c-9775dabfa04c
Commits

Reviewing files that changed from the base of the PR and between c2adad6 and 3a70ebd.

Files selected for processing: 2
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main__azure.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/azure-integration-test/trusted-execution-clusters-ref-azure-integration-test-commands.sh

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2026
@Jakob-Naucke

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

to accelerate tests

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
We have seen the test time out from the default 2h. Allow 3h.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jakob-Naucke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jakob-Naucke: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-trusted-execution-clusters-operator-main-azure-images trusted-execution-clusters/operator presubmit Ci-operator config changed
pull-ci-trusted-execution-clusters-operator-main-azure-integration-test trusted-execution-clusters/operator presubmit Ci-operator config changed
pull-ci-trusted-execution-clusters-operator-main-images trusted-execution-clusters/operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Jakob-Naucke

Jakob-Naucke commented Nov 4, 2026 via email

Copy link
Copy Markdown
Member Author

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Jakob-Naucke Jakob-Naucke changed the title trusted-execution-clusters: Bump to OpenShift 5.0 trusted-execution-clusters: Bump to OCP 5.0 Nov 4, 2026
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/trusted-execution-clusters/operator/main/azure-integration-test 3a70ebd link unknown /pj-rehearse pull-ci-trusted-execution-clusters-operator-main-azure-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant