NO-JIRA: common.yaml: re-enable composefs on el9 by jlebon · Pull Request #1735 · openshift/os

jlebon · 2025-02-03T16:27:06Z

The composefs issue (https://issues.redhat.com/browse/RHEL-63985)
should now be fixed in the latest el9 kernel. So let's optimistically
re-enable it. Now that we have tests for now, CI will validate this for
us as well.

jlebon · 2025-02-03T17:19:53Z

/assign @travier

dustymabe · 2025-02-03T21:25:14Z

    if [ -f /usr/lib/ostree/prepare-root.conf ] && [[ $(rpm -q kernel) = *.el9.* ]]; then
      grep -q 'enabled = true' /usr/lib/ostree/prepare-root.conf
-      sed -i -e 's,enabled = true,enabled = no,' /usr/lib/ostree/prepare-root.conf
+      sed -i -e 's,enabled = true,enabled = maybe,' /usr/lib/ostree/prepare-root.conf


enabled = maybe is definitely an interesting value to allow :(

dustymabe

/lgtm

jlebon · 2025-02-04T13:38:33Z

/retest

jlebon · 2025-02-06T21:33:33Z

/retest

openshift-ci-robot · 2025-02-06T21:34:18Z

@jlebon: This pull request explicitly references no jira issue.

Details

In response to this:

The composefs issue (https://issues.redhat.com/browse/RHEL-63985)
should now be fixed in the latest el9 kernel. So let's optimistically
re-enable it. Now that we have tests for now, CI will validate this for
us as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dustymabe · 2025-02-10T18:06:23Z

looks like some of prow is still testing against 9.4. #1742 should handle some of the rework needed to stop that.

jlebon · 2025-02-10T21:55:41Z

Hmm, the ostree.sync error looks persistent.

 --- FAIL: ostree.sync (161.55s)
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs1/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs2/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs3/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs4/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs5/share failed, reason given by server: No such file or directory
        cluster.go:151: mount.nfs4: mounting 10.0.2.2:/var/nfs6/share failed, reason given by server: No such file or directory
        cluster.go:173: "for i in $(seq 6); do\n\t\t\tsudo mount -t nfs4 10.0.2.2:/var/nfs$i/share /var/tmp/data$i\n\t\t\tdone" failed: output , status Process exited with status 32

@HuijingHei do you know what's going on here? Looks like ostree.sync + composefs is failing. Though the error looks different from #1720.

HuijingHei · 2025-02-12T11:50:47Z

do you know what's going on here? Looks like ostree.sync + composefs is failing.

Can reproduce locally (add kernel argument ostree.prepare-root.composefs=1 in butane config in ostree.sync, refer to doc), will look at more about it.

The composefs issue (https://issues.redhat.com/browse/RHEL-63985) should now be fixed in the latest el9 kernel. So let's optimistically re-enable it. Now that we have tests for now, CI will validate this for us as well.

We don't care about 9.4 anymore.

It's cleaner that way. Follow-up to 3f53dd3.

That test is currently hitting issues when composefs is re-enabled: openshift#1744 While we look into it, let's denylist it so we get more composefs testing downstream. Note there's already another entry for that same test on s390x, but let's keep them separate since they seem to be separate issues.

jlebon · 2025-02-13T14:50:58Z

Rebased and added a denylist entry for ostree.sync for now!

openshift-ci · 2025-02-13T17:24:42Z

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/rhcos-96-build-test-qemu	`f6d7094`	link	true	`/test rhcos-96-build-test-qemu`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jlebon · 2025-02-13T18:54:44Z

/retest
/label acknowledge-critical-fixes-only

jlebon · 2025-02-13T20:30:45Z

/override ci/prow/e2e-aws
/override ci/prow/images

This will be fixed soon (coreos/fedora-coreos-pipeline#1091).

openshift-ci · 2025-02-13T20:31:03Z

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

This will be fixed soon (coreos/fedora-coreos-pipeline#1091).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jbtrystram · 2025-02-13T21:45:29Z

/lgtm

openshift-ci · 2025-02-13T21:45:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jbtrystram, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dustymabe,jbtrystram,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-02-13T22:01:06Z

/retest-required

Remaining retests: 0 against base HEAD e1a1926 and 2 for PR HEAD 870c2ef in total

openshift-ci Bot requested review from aaradhak and gursewak1997 February 3, 2025 16:29

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025

openshift-ci Bot assigned travier Feb 3, 2025

dustymabe reviewed Feb 3, 2025

View reviewed changes

dustymabe approved these changes Feb 3, 2025

View reviewed changes

openshift-ci Bot assigned dustymabe Feb 3, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025

jlebon changed the title ~~common.yaml: re-enable composefs on el9~~ NO-JIRA: common.yaml: re-enable composefs on el9 Feb 6, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025

dustymabe mentioned this pull request Feb 10, 2025

NO-JIRA: rework manifests and drop mentions of 9.4 #1742

Merged

HuijingHei mentioned this pull request Feb 13, 2025

ostree.sync + composefs failed #1744

Closed

jlebon added 4 commits February 13, 2025 09:45

common.yaml: re-enable composefs on el9

b251ede

The composefs issue (https://issues.redhat.com/browse/RHEL-63985) should now be fixed in the latest el9 kernel. So let's optimistically re-enable it. Now that we have tests for now, CI will validate this for us as well.

denylist: drop 9.4-only entry

0f0474f

We don't care about 9.4 anymore.

packages-openshift: use mountpoint instead of findmnt

2a3eaf6

It's cleaner that way. Follow-up to 3f53dd3.

jlebon force-pushed the pr/composefs-reenable branch from f6d7094 to 870c2ef Compare February 13, 2025 14:50

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025

jlebon mentioned this pull request Feb 13, 2025

NO-JIRA: Containerfile: use secrets API for yum repo injection #1740

Merged

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 13, 2025

openshift-ci Bot assigned jbtrystram Feb 13, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025

openshift-merge-bot Bot merged commit b3e1fa1 into openshift:master Feb 14, 2025

dustymabe mentioned this pull request Apr 21, 2025

Turning on composefs breaks pivot from old bootimages #1678

Open

Conversation

jlebon commented Feb 3, 2025

Uh oh!

jlebon commented Feb 3, 2025

Uh oh!

dustymabe Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

dustymabe left a comment

Choose a reason for hiding this comment

Uh oh!

jlebon commented Feb 4, 2025

Uh oh!

jlebon commented Feb 6, 2025

Uh oh!

openshift-ci-robot commented Feb 6, 2025

Uh oh!

dustymabe commented Feb 10, 2025

Uh oh!

jlebon commented Feb 10, 2025

Uh oh!

HuijingHei commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jlebon commented Feb 13, 2025

Uh oh!

openshift-ci Bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jlebon commented Feb 13, 2025

Uh oh!

jlebon commented Feb 13, 2025

Uh oh!

openshift-ci Bot commented Feb 13, 2025

Uh oh!

jbtrystram commented Feb 13, 2025

Uh oh!

openshift-ci Bot commented Feb 13, 2025

Uh oh!

openshift-ci-robot commented Feb 13, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HuijingHei commented Feb 12, 2025 •

edited

Loading

openshift-ci Bot commented Feb 13, 2025 •

edited

Loading