Skip to content

OCPBUGS-89943: Replace golang.org/x/crypto with sustaining fork for CVE-2026-39829 in release-4.19 - #1534

Open
atewari-rh wants to merge 1 commit into
openshift:release-4.19from
atewari-rh:local_release-4.19
Open

atewari-rh wants to merge 1 commit into
openshift:release-4.19from
atewari-rh:local_release-4.19

Conversation

@atewari-rh

Copy link
Copy Markdown

What

Replaces golang.org/x/crypto with the sustaining team's patched fork
(github.com/openshift-sustaining/crypto@v0.41.0-sec.3) to fix
CVE-2026-39829 — a DoS in
golang.org/x/crypto/ssh from unbounded RSA/DSA key parameters.

Why a fork

Upstream fix is in v0.52.0, but that requires a newer Go toolchain than release-4.19
carries (go 1.23.0). The fork backports the fix without a Go bump:

```
go mod edit -replace golang.org/x/crypto=github.com/openshift-sustaining/crypto@v0.41.0-sec.3
go mod tidy && go mod vendor
```

Changes

  • go.mod: added the replace directive + transitive bumps pulled in by the fork's go.mod
  • vendor/golang.org/x/crypto/**, vendor/modules.txt: regenerated via go mod vendor
  • No Go version/toolchain change, no application source changes

Testing

  • make build / go build -mod=vendor ./... — clean
  • vendor/golang.org/x/crypto/ssh/keys.go contains the patched 8192-bit RSA modulus check
  • make test: 17/18 test functions pass. TestDefaultAzureProviderSpec fails on arm64
    hosts only
    — pre-existing, unrelated bug (test doesn't account for arch == ARM64 logic
    in machine_webhook.go). Confirmed via git stash this fails identically without this
    change too; not release-blocking since CI runs on amd64.

Related: OCPBUGS-89943

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b017e43a-9264-4934-852f-29c4e013a511

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from elmiko and nrb August 14, 2026 09:09
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Hi @atewari-rh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atewari-rh atewari-rh changed the title [release-4.19] Replace golang.org/x/crypto with sustaining fork for CVE-2026-39829 OCPBUGS-89943: Replace golang.org/x/crypto with sustaining fork for CVE-2026-39829 in release-4.19 Sep 30, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@atewari-rh: This pull request references Jira Issue OCPBUGS-89943, which is invalid:

  • expected dependent Jira Issue OCPBUGS-89982 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What

Replaces golang.org/x/crypto with the sustaining team's patched fork
(github.com/openshift-sustaining/crypto@v0.41.0-sec.3) to fix
CVE-2026-39829 — a DoS in
golang.org/x/crypto/ssh from unbounded RSA/DSA key parameters.

Why a fork

Upstream fix is in v0.52.0, but that requires a newer Go toolchain than release-4.19
carries (go 1.23.0). The fork backports the fix without a Go bump:

```
go mod edit -replace golang.org/x/crypto=github.com/openshift-sustaining/crypto@v0.41.0-sec.3
go mod tidy && go mod vendor
```

Changes

  • go.mod: added the replace directive + transitive bumps pulled in by the fork's go.mod
  • vendor/golang.org/x/crypto/**, vendor/modules.txt: regenerated via go mod vendor
  • No Go version/toolchain change, no application source changes

Testing

  • make build / go build -mod=vendor ./... — clean
  • vendor/golang.org/x/crypto/ssh/keys.go contains the patched 8192-bit RSA modulus check
  • make test: 17/18 test functions pass. TestDefaultAzureProviderSpec fails on arm64
    hosts only
    — pre-existing, unrelated bug (test doesn't account for arch == ARM64 logic
    in machine_webhook.go). Confirmed via git stash this fails identically without this
    change too; not release-blocking since CI runs on amd64.

Related: OCPBUGS-89943

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prdhamdh

Copy link
Copy Markdown

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@openshift-ci

openshift-ci Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@atewari-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants