Skip to content

OCPBUGS-82111: contain hookProvider errors so a plugin cannot white-screen Console #17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pratik-Redhat-Tech wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

OCPBUGS-82111: contain hookProvider errors so a plugin cannot white-screen Console #17433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions frontend/packages/console-app/src/components/flags/FeatureFlagExtensionLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import type { ResolvedExtension } from '@console/dynamic-plugin-sdk/src/types';
import { setFlag, updateModelFlags } from '@console/internal/actions/flags';
import type { OnChange } from '@console/plugin-sdk/src/utils/useCompareExtensions';
import { useCompareExtensions } from '@console/plugin-sdk/src/utils/useCompareExtensions';
import { ErrorBoundary } from '@console/shared/src/components/error/error-boundary';
import { useConsoleDispatch } from '@console/shared/src/hooks/useConsoleDispatch';
import { useConsoleSelector } from '@console/shared/src/hooks/useConsoleSelector';
import { FeatureFlagExtensionHookResolver } from './FeatureFlagExtensionHookResolver';
Expand Down Expand Up @@ -136,12 +137,17 @@ export const FeatureFlagExtensionLoader: FC = () => {
properties: { handler },
uid,
} = nf;
// hookProvider handlers are React hooks, so they cannot be wrapped in
// try/catch (Rules of Hooks). console.flag handlers already catch
// errors; without a boundary here a throw unmounts the whole app
// (FeatureFlagExtensionLoader sits outside the page ErrorBoundary).
return (
<FeatureFlagExtensionHookResolver
key={uid}
handler={handler}
setFeatureFlag={featureFlagController}
/>
<ErrorBoundary key={uid}>
<FeatureFlagExtensionHookResolver
handler={handler}
setFeatureFlag={featureFlagController}
/>
</ErrorBoundary>
);
})}
</>
Expand Down