Skip to content

[release-4.22] OCPBUGS-132340: Remove early "analytics.page()" on Segment init - #17401

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-17178-to-release-4.22
Open

[release-4.22] OCPBUGS-132340: Remove early "analytics.page()" on Segment init#17401
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-17178-to-release-4.22

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 20, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #17178

/assign MatousJobanek

@MikelAlejoBR @openshift-cherrypick-robot
OCPBUGS-114708: Remove early "analytics.page()" on Segment init
2a4c271 
Segment initialization immediately called "analytics.page()" after
"analytics.load()", before identity ran. That sent an anonymous page
event to Segment on sampled sessions, which may have contributed to
short-lived sessions being reported in analytics.

Page views are still sent via the normal telemetry flow after the user
is identified, via segment.ts.

https://issues.redhat.com/browse/OCPBUGS-114708
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2026
Merged
3 tasks done
@openshift-merge-bot

openshift-merge-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci
openshift-ci Bot requested review from Leo6Leo and spadgett October 20, 2026 02:06
@openshift-ci openshift-ci Bot added component/sdk Related to console-plugin-sdk plugin-api-changed Categorizes a PR as containing plugin API changes labels Oct 20, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-114708 has been cloned as Jira Issue OCPBUGS-132340. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-132340: Remove early "analytics.page()" on Segment init

Details

In response to this:

This is an automated cherry-pick of #17178

/assign MatousJobanek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-114708: Remove early "analytics.page()" on Segment init [release-4.22] OCPBUGS-132340: Remove early "analytics.page()" on Segment init Oct 20, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 20, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-132340, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-114708 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-114708 to target a version in 5.0.0, but it targets "5.1" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #17178

/assign MatousJobanek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot

openshift-merge-robot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@openshift-merge-robot: This pull request references Jira Issue OCPBUGS-132340, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-114708 to target a version in 5.0.0, but it targets "5.1" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

spadgett
spadgett approved these changes Oct 21, 2026
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/backport-risk-assessed

@spadgett

spadgett commented Oct 21, 2026

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@spadgett

spadgett commented Oct 21, 2026

Copy link
Copy Markdown
Member

/label plugin-api-approved

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer lgtm Indicates that a PR is ready to be merged. labels Oct 21, 2026
@openshift-ci

openshift-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes
@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@vojtechszocs vojtechszocs

@spadgett spadgett

@MatousJobanek MatousJobanek

@jhadvig jhadvig

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/sdk Related to console-plugin-sdk jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @openshift-merge-robot @spadgett @vojtechszocs @MatousJobanek @jhadvig @logonoff @MikelAlejoBR