Repository navigation
NO-JIRA: add prettier to playwright folder - #17137
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@logonoff: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (83)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughFormatting-only updates align frontend E2E support code and test suites with the configured Prettier and Playwright ESLint styles. Runtime behavior, selectors, assertions, APIs, and test flows remain unchanged. ChangesFrontend E2E formatting
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The changes only align E2E code with the new Prettier lint configuration, with no supported runtime or test-loading regression remaining. Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
Full details: Description checkExplanation The description includes the root cause and solution, but it omits the required screenshots, test setup, test cases, browser conformance, additional information, and reviewer or assignee sections. It also does not provide a Jira issue reference. Full details: Docstring CoverageExplanation Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 50 files. (32 skipped: 32 over the file limit.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes Playwright E2E formatting and ESLint configuration. No Ginkgo Full details: Test Structure And QualityExplanation PASS: The custom check is scoped to Ginkgo test code. The PR changes only TypeScript files under Full details: Microshift Test CompatibilityExplanation PASS — The pull request changes 83 existing TypeScript files only. The diff adds no Go files or new files, and searches found no Ginkgo imports or Ginkgo declarations. The e2e tests use Playwright APIs such as Full details: Single Node Openshift (Sno) Test CompatibilityExplanation The SNO check is not applicable. The PR changes only 83 existing TypeScript files, all with status M; it adds no files and changes no Go files. The changed tests use Playwright, and the added diff contains no Ginkgo declarations or SNO-related test logic. The ESLint change only adds the Prettier configuration to the Playwright scope. Full details: Topology-Aware Scheduling CompatibilityExplanation The check is not triggered. The PR changes only Full details: Ote Binary Stdout ContractExplanation PASS: The PR changes only 83 TypeScript files under Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS. The PR changes only TypeScript files, including existing Playwright tests and the ESLint configuration. The diff adds no Ginkgo declarations ( Full details: No-Weak-CryptoExplanation PASS: The pull request adds only the Prettier ESLint extension and reformats e2e files. Boundary-aware scans of all added lines found no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom crypto APIs, crypto imports, or timing-sensitive comparison APIs. No weak-crypto condition was introduced. Full details: Container-PrivilegesExplanation PASS. The pull request changes only 83 TypeScript files under Full details: No-Sensitive-Data-In-LogsExplanation PASS. The pull-request diff adds no new logging sink. The only apparent added
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/label px-approved No runtime or test changes whatsoever, literally just changing whitespace. Going to override CI for this one |
openshift-ci
Bot
added
px-approved
openshift-ci-robot
added
the
verified
|
@logonoff: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pipeline required |
|
Scheduling tests matching the |
|
@logonoff: /override-sticky requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override-sticky ci/prow/e2e-cypress |
|
@logonoff: Overrode contexts on behalf of logonoff: ci/prow/e2e-cypress, ci/prow/e2e-gcp-console, ci/prow/e2e-gcp-console-techpreview These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
failure is unrelated /override-sticky ci/prow/okd-scos-images |
|
@logonoff: Overrode contexts on behalf of logonoff: ci/prow/okd-scos-images These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve cc: @vikram-raj, @shahsahil264 since this will impact your migration PRs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Analysis / Root cause:
Prettier was never added to linting config
Solution description:
Add it to the linting config and run prettier on the tests
Summary by CodeRabbit
Style
Chores