Skip to content

Fix OCPBUGS-98765: CVE-2026-48801 - #16855

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.19from
germanparente:fix-CVE-2026-48801-release-4.19
Aug 31, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.19from
germanparente:fix-CVE-2026-48801-release-4.19

Conversation

@germanparente

Copy link
Copy Markdown
Contributor

Summary

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3f1ba18d-7f07-43a0-93a4-57d08542a5d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: This pull request references Jira Issue OCPBUGS-98765, which is invalid:

  • expected dependent Jira Issue OCPBUGS-98785 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from TheRealJon and spadgett July 27, 2026 18:58
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jul 27, 2026
germanparente and others added 2 commits August 24, 2026 15:37
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add __mocks__/linkify-react.js for Jest auto-resolution
- Add moduleNameMapper to route ESM import to mock
- Remove linkify-react from transformIgnorePatterns
- Remove unused react-linkify import and config from app

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@germanparente
germanparente force-pushed the fix-CVE-2026-48801-release-4.19 branch from abbc3bb to a74e5a8 Compare August 24, 2026 13:37
@germanparente

Copy link
Copy Markdown
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 24, 2026
@germanparente

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: This pull request references Jira Issue OCPBUGS-98765, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-98785 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-98785 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown
Contributor Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console

@germanparente

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

3 similar comments
@germanparente

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@germanparente

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@germanparente

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@germanparente

Copy link
Copy Markdown
Contributor Author

The PR replaces react-linkify (which depends on vulnerable linkify-it) with linkify-react + linkifyjs to fix CVE-2026-48801 (quadratic complexity DoS in linkify-it's match scan loop).

Changes look correct:

  1. frontend/package.json — Removes react-linkify, adds linkify-react + linkifyjs ^4.2.0, adds Jest mock mapping for the new module
  2. frontend/mocks/linkify-react.js — Simple mock for unit tests, renders children in a span
  3. frontend/public/components/app.jsx — Removes the old linkify.set({ fuzzyLink: false }) global config (no longer needed since the new library uses explicit URL validation)
  4. frontend/public/components/utils/link.tsx — Replaces the react-linkify Linkify component with linkify-react's version. The linkifyOptions config properly:
    • Renders links with target="_blank" and rel="noopener noreferrer" (same behavior as before)
    • Validates URLs to only match https?:// (replaces the old fuzzyLink: false setting)
  5. frontend/yarn.lock — Cleanly removes react-linkify, linkify-it, tlds, uc.micro and adds linkify-react + linkifyjs 4.3.3

All CI checks (analyze, backend, frontend, images) passed. The e2e failure is unrelated. PR looks good to merge.

Then:

/override ci/prow/e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@germanparente: Overrode contexts on behalf of germanparente: ci/prow/e2e-gcp-console

Details

In response to this:

The PR replaces react-linkify (which depends on vulnerable linkify-it) with linkify-react + linkifyjs to fix CVE-2026-48801 (quadratic complexity DoS in linkify-it's match scan loop).

Changes look correct:

  1. frontend/package.json — Removes react-linkify, adds linkify-react + linkifyjs ^4.2.0, adds Jest mock mapping for the new module
  2. frontend/mocks/linkify-react.js — Simple mock for unit tests, renders children in a span
  3. frontend/public/components/app.jsx — Removes the old linkify.set({ fuzzyLink: false }) global config (no longer needed since the new library uses explicit URL validation)
  4. frontend/public/components/utils/link.tsx — Replaces the react-linkify Linkify component with linkify-react's version. The linkifyOptions config properly:
  • Renders links with target="_blank" and rel="noopener noreferrer" (same behavior as before)
  • Validates URLs to only match https?:// (replaces the old fuzzyLink: false setting)
  1. frontend/yarn.lock — Cleanly removes react-linkify, linkify-it, tlds, uc.micro and adds linkify-react + linkifyjs 4.3.3

All CI checks (analyze, backend, frontend, images) passed. The e2e failure is unrelated. PR looks good to merge.

Then:

/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prabhapa

Copy link
Copy Markdown

/lgtm
/label approved

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, prabhapa
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2026
@germanparente

Copy link
Copy Markdown
Contributor Author

as this one has been lgtm'd:

/label approved

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5a48a95 and 2 for PR HEAD a74e5a8 in total

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@germanparente: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3c3975e into openshift:release-4.19 Aug 31, 2026
7 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: Jira Issue Verification Checks: Jira Issue OCPBUGS-98765
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98765 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants