Repository navigation
Fix KNX protocol test registration race - #3495
Merged
Merged
Conversation
Wait for both status and command datapoints to be registered before sending attribute writes, preventing the first command from being dropped. Synchronize registration checks and make shared test-link fields volatile to ensure visibility across threads. Fixes #3494
|
MartinaeyNL
reviewed
Oct 26, 2026
Contributor
I'm on it 🫡 |
Contributor
|
So far ran 35x no issues with this test. Did find 2 MapResource tests that failed: https://github.com/openremote/core/actions/runs/40328942925/job/122086965785?pr=3495 And the MQTTBrokerTest failed twice: https://github.com/openremote/core/actions/runs/40328942925/job/122037946898?pr=3495 and https://github.com/openremote/core/actions/runs/40328942925/job/121931365172 |
Ekhorn
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wait for both status and command datapoints to be registered before sending attribute writes, preventing the first command from being dropped.
Synchronize registration checks and make shared test-link fields volatile to ensure visibility across threads.
Fixes #3494
Checklist