Repository navigation
Preserve caller path filters in asset-scoped rules queries - #3488
Merged
Merged
Conversation
ebariaux
added
the
Breaking Change
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asset-scoped rules currently replace caller-supplied path filters with the engine's asset path. A query for a descendant subtree can therefore return the engine's entire subtree, and an explicitly empty path selection can return assets.
Preserve the caller's path alternatives and apply the engine subtree as a separate required condition in the storage query, before ordering and pagination. Results must satisfy both the caller's filters and the engine's realm/subtree restrictions. Empty path arrays continue to return no assets, and recursive queries remain constrained to the engine subtree.
Fixes #3479. Related to #2675.
Compatibility and integration
Rules that supply path filters may now return fewer assets because those filters are respected. Rules without a path filter retain their existing scope. No query schema changes are introduced.
Caller-query isolation is handled separately in #3481. When combining the changes, its facade unit-test stubs and path expectations need to reflect the separate required-path storage argument.
The new storage overload documents its filtering behavior and caller authorization responsibility.