Repository navigation
Conversation
wborn
added
dependencies
Upgrade Groovy to 6.0.0, Spock to 2.5-groovy-6.0, and iCal4j to 4.4.0. - Add the groovy-callsite dependency for compatibility with iCal4j's legacy Groovy extensions. - Replace wildcard generic type arguments in constructor calls with the diamond operator. - Move JUL logging initialization from ContainerTrait's static initializer to the Spock TestFixture extension to avoid initialization failures with Groovy 6. Groovy 6 release notes: https://groovy-lang.org/releasenotes/groovy-6.0.html
|
There was a problem hiding this comment.
Rulesets recompile under Groovy 6. Groovy rules are compiled at runtime (RulesetDeployment), so existing user rules silently get Groovy 6 semantics: key in map is now key-based, for-in closure capture is per-iteration, unmatched switch expressions throw instead of returning null, val is now a keyword.
Please add release notes + the -Dgroovy.* porting flags.
There was a problem hiding this comment.
iCal4j 4.4.0 changes recurrence results ("missing yearly recurrences for UTC DTSTART", "recurrence counts with repeated selectors"). Schedules/validity windows can shift. → please test yearly RRULEs and UNTIL cases.
MartinaeyNL
added
the
Breaking Change
|
Not sure if this touches with any work @ebariaux was doing for the Groovy sandboxing? |
|
Maybe it's also worth to test several custom-project Groovy rules with version 6, to see if the breaking changes are major. |
Description
Upgrade Groovy to 6.0.0, Spock to 2.5-groovy-6.0, and iCal4j to 4.4.0.
Groovy 6 release notes:
https://groovy-lang.org/releasenotes/groovy-6.0.html
Checklist