Skip to content

LoaderClient throws NPE when a different computer is loading stuff #71

Open

Description

@balazsracz

when there are multiple computers on a network, it is possible to have JMRI running and a firmware update be happening over the network from another computer.

I am getting NPE in the JMRI console when I'm doing this:

2017-01-14 13:19:47,559 jmrix.AbstractMRTrafficController WARN - notify: During reply dispatch to jmri.jmrix.openlcb.OlcbConfigurationManager$2@6fe0860f [AWT-EventQueue-0]
java.lang.NullPointerException
at org.openlcb.LoaderClient.sendStreamNext(LoaderClient.java:255)
at org.openlcb.LoaderClient.handleStreamDataProceed(LoaderClient.java:278)
at org.openlcb.StreamDataProceedMessage.applyTo(StreamDataProceedMessage.java:39)
at org.openlcb.MessageDecoder.put(MessageDecoder.java:34)
at org.openlcb.OlcbInterface$MessageDispatcher.put(OlcbInterface.java:189)
at org.openlcb.can.CanInterface$FrameParser.send(CanInterface.java:124)
at jmri.jmrix.openlcb.OlcbConfigurationManager$2.reply(OlcbConfigurationManager.java:385)
at jmri.jmrix.can.adapters.gridconnect.GcTrafficController.forwardReply(GcTrafficController.java:42)
at jmri.jmrix.AbstractMRTrafficController.notifyReply(AbstractMRTrafficController.java:191)
at jmri.jmrix.AbstractMRTrafficController$RcvNotifier.run(AbstractMRTrafficController.java:1040)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:301)

Activity

  1. pabender commented on Jan 14, 2017

    @pabender
    Member
  2. balazsracz commented on Jan 14, 2017

    @balazsracz
    CollaboratorAuthor
  3. dpharris commented on Apr 11, 2023

    @dpharris
    Contributor

    Is this still an active issue?

  4. bobjacobsen commented on Apr 11, 2023

    @bobjacobsen
    Contributor

    I haven't been able to recreate it with two JMRI instances.

    But reading the traceback, it looks like the Other Computer was doing stream-based I/O. I might not have been recreating it correctly because JMRI uses datagrams to do firmware download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions