Skip to content

Some classes have virtual functions but not virtual constructors, causing -Werror=non-virtual-dtor #105

Open

Description

@Splanzar

We have -Wnon-virtual-dtor -Wall -Werror in our g++ command which compiles with mFast headers. We are getting below issues:

..../mfast/instructions/template_instruction.h:50:7: error: ‘class mfast::template_instruction_ex<template_shse::hkSnapshot_cref>’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]

We need to find out all the classes with similar issues and add virtual destructors to them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions