Repository navigation
TW-4986: fix(calendar): fix recurring events API and integration tests - #8
Merged
Merged
Conversation
This commit fixes two issues with recurring event functionality:
1. API Parameter Fix (calendars_virtual_recurring.go):
- Changed query parameter from `event_id` to `master_event_id`
- The Nylas v3 API requires `master_event_id` to fetch instances
of a recurring event series
- Previous parameter caused "schema: invalid path event_id" error
2. Integration Test Fix (recurring_events_test.go):
- Changed calendar selection from "first non-read-only" to "primary"
- The first calendar returned is often "Holidays" (read-only)
- Other shared calendars may also reject event creation
- Only the primary calendar reliably allows event modifications
Updated unit tests to verify the correct API parameter is used.
Fixes: TestRecurringEventOperations, TestRecurringEventPatterns
qasim-nylas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues with recurring event functionality:
API Parameter Fix (calendars_virtual_recurring.go):
event_idtomaster_event_idmaster_event_idto fetch instances of a recurring event seriesIntegration Test Fix (recurring_events_test.go):
Updated unit tests to verify the correct API parameter is used.
Fixes: TestRecurringEventOperations, TestRecurringEventPatterns