Repository navigation
TW-5028: Add codeowners - #1
Merged
Merged
Conversation
radenkovic
added a commit
that referenced
this pull request
Sep 30, 2026
…w window Addresses review items #1-#5 on #123: - #1 oauth login clears the stored session under the lock before writing the new one, and again if the write fails, so a failed login against another server never leaves the old refresh token filed under the new server's name. - #2 config reset clears the dashboard and OAuth sessions under their cross-process locks, so an in-flight mcp serve refresh cannot write the session back. - #3 dashboard session renewal, login and clear run under a new dashboard-session.lock and re-check expiry once it is held, so concurrent renewals exchange once and never interleave keys. A separate lock is used because renewal asks the OAuth session for a token, which may take oauth-session.lock; the order is always dashboard, then OAuth, then .secrets.lock. oauth logout holds the dashboard lock across the dashboard clear and the OAuth logout, keeping the dashboard-first order. - #4 the renewer asks for an access token valid for at least the renew window (AccessTokenValidFor), so a re-exchange gets a new expiry. - #5 oauth login keeps an existing `nylas dashboard login` session for the configured server instead of silently replacing it, and says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add codeowners