Performance of node:fs #106

Activity

1. anonrig commented on Sep 17, 2023

   

   anonrig

   on Sep 17, 2023

   Last edited by anonrig

   MemberAuthor

   More actions

   Sync methods

   • fs.accessSync(path[, mode]) fs: improve error performance of sync methods node#49593
   • fs.appendFileSync(path, data[, options])
   • fs.chmodSync(path, mode) fs: improve error perf of sync chmod+fchmod node#49859
   • fs.chownSync(path, uid, gid) fs: improve error performance of chownSync node#49748
   • fs.closeSync(fd) fs: improve error performance of sync methods node#49593
   • fs.copyFileSync(src, dest[, mode]) fs: improve error performance of sync methods node#49593
   • fs.cpSync(src, dest[, options])
   • fs.existsSync(path) fs: improve error performance of sync methods node#49593
   • fs.fchmodSync(fd, mode) fs: improve error perf of sync chmod+fchmod node#49859
   • fs.fchownSync(fd, uid, gid) fs: throw fchownSync error from c++ node#51075
   • fs.fdatasyncSync(fd) fs: improve error performance for fdatasyncSync node#49898
   • fs.fstatSync(fd[, options]) fs: improve error perf of sync lstat+fstat node#49868
   • fs.fsyncSync(fd) fs: improve error performance for fsyncSync node#49880
   • fs.ftruncateSync(fd[, len]) fs: improve error performance for ftruncateSync node#50032
   • fs.futimesSync(fd, atime, mtime) fs: improve error perf of sync *times node#49864
   • fs.lchmodSync(path, mode)
   • fs.lchownSync(path, uid, gid) node:fs error path performance improvements node#49962
   • fs.lutimesSync(path, atime, mtime) fs: improve error perf of sync *times node#49864
   • fs.linkSync(existingPath, newPath) node:fs error path performance improvements node#49962
   • fs.lstatSync(path[, options]) fs: improve error perf of sync lstat+fstat node#49868
   • fs.mkdirSync(path[, options]) fs: improve error performance for mkdirSync node#49847
   • fs.mkdtempSync(prefix[, options]) fs: improve error performance for fs.mkdtempSync node#49750
   • fs.opendirSync(path[, options]) fs: improve error performance of opendirSync node#49705
   • fs.openSync(path[, flags[, mode]]) fs: improve error performance of sync methods node#49593
   • fs.readdirSync(path[, options]) fs: improve error performance of readdirSync node#50131
   • fs.readFileSync(path[, options]) fs: improve readFileSync with file descriptors node#49691
   • fs.readlinkSync(path[, options]) node:fs error path performance improvements node#49962
   • fs.readSync(fd, buffer, offset, length[, position]) fs: improve error performance for readSync node#50033
   • fs.readSync(fd, buffer[, options]) fs: improve error performance for readSync node#50033
   • fs.readvSync(fd, buffers[, position]) fs: improve error performance of readvSync node#50100
   • fs.realpathSync(path[, options])
   • fs.realpathSync.native(path[, options])
   • fs.renameSync(oldPath, newPath) fs: improve error performance for fs.renameSync node#49863
   • fs.rmdirSync(path[, options]) fs: improve error performance for rmdirSync node#49846
   • fs.rmSync(path[, options])
   • fs.statSync(path[, options]) fs: improve error performance of sync methods node#49593
   • fs.statfsSync(path[, options]) fs: improve error performance of sync methods node#49593
   • fs.symlinkSync(target, path[, type]) node:fs error path performance improvements node#49962
   • fs.truncateSync(path[, len]) fs: improve error performance for ftruncateSync node#50032
   • fs.unlinkSync(path) fs: improve error performance for unlinkSync node#49856
   • fs.utimesSync(path, atime, mtime) fs: improve error perf of sync *times node#49864
   • fs.writeFileSync(file, data[, options])
   • fs.writeSync(fd, buffer, offset[, length[, position]]) fs: improve error performance of fs.writeSync node#50923
   • fs.writevSync(fd, buffers[, position])

   👍React with 👍5Reacted by Yisi, Pedro Alonso, Thanveer, Suraj and Mert Can Altin

   ❤️React with ❤️48Reacted by Carlos Fuentes, Nicolas DUBIEN, Rohan Verma, Michael, Anas Zahouri, Gürgün Dayıoğlu, Shrujal Shah, Corbin Crutchley, Toni Villena, Chen Chang and 38 more

   🚀React with 🚀9Reacted by İbrahim Sarıkaya, Colin McDonnell, Reece Dunham, Thanveer, Vinicius Lourenço, Oliver Medhurst, Suraj, Jonas and Mert Can Altin
2. anonrig

   self-assigned this

   on Sep 17, 2023
3. anonrig

   added

   performance-agenda

   on Sep 17, 2023
4. tony-go commented on Sep 19, 2023

   

   tony-go

   on Sep 19, 2023

   Member

   More actions

   It's definitely a good idea to tackle syncs as we don't have to handle callbacks in c++ land as with async methods.

   👍React with 👍3Reacted by Yagiz Nizipli, Kardeş Yazılım and Suraj
5. nodejs-github-bot

   added a commit that references this issue on Sep 21, 2023

   fs: improve error performance of `opendirSync`

   ...

   571ecbf
6. CanadaHonk commented on Sep 26, 2023

   

   CanadaHonk

   on Sep 26, 2023

   Last edited by CanadaHonk

   Member

   More actions

   Would rimraf likely benefit from being rewritten in C++ rather than in JS using FS APIs? Potential issue/idea for the future.

   👍React with 👍2Reacted by Yagiz Nizipli and Suraj
7. CanadaHonk commented on Sep 26, 2023

   

   CanadaHonk

   on Sep 26, 2023

   Last edited by CanadaHonk

   Member

   More actions

   Encoding C++ fast paths

   utf8

   • readFileSync fs: add a fast-path for readFileSync utf-8 node#48658
   • writeFileSync fs: add c++ fast path for writeFileSync string utf8 node#49884

   ascii/latin1

   ascii/latin1 allows using one byte V8 strings in/out which can save string copies and potentially lead to some speedups (needs investigation).

   See also: nodejs/node#49888

   👍React with 👍4Reacted by Yagiz Nizipli, Vinicius Lourenço, Carlos Fuentes and Mert Can Altin
8. benjamingr commented on Sep 27, 2023

   

   benjamingr

   on Sep 27, 2023

   Member

   More actions

   readfile intentionally splits the file into many reads to avoid contention but that could could live in C++ and readFile would could be a single JS->CPP call (and one CPP->JS for the callback)

   👍React with 👍1Reacted by Zhenwei Jin
9. CanadaHonk commented on Sep 27, 2023

   

   CanadaHonk

   on Sep 27, 2023

   Member

   More actions

   ^ fwiw this only happens in current non-fast path atm (non-utf8 encoding)
10. Uzlopak commented on Sep 27, 2023

    

    Uzlopak

    on Sep 27, 2023

    Contributor

    More actions

    Should we maybe put in the docs, that using a number instead of a string for mode is significantly faster?

    nodejs/node#49756 (comment)
11. Uzlopak commented on Sep 27, 2023

    

    Uzlopak

    on Sep 27, 2023

    Contributor

    More actions

    My benchmarks show that using a string for mode is about 12 Million ops/s and a number about 250 Million ops/s. My suggestion for string in the above comment makes it about 80 Million ops/s for but is still slower than simply to use a number.
12. CanadaHonk commented on Sep 27, 2023

    

    CanadaHonk

    on Sep 27, 2023

    Member

    More actions

    It could also be interesting to make a Node option/something which would log/warn when missing potential faster internal/FS paths (eg readFileSync utf8 encoding, or using a string as a mode, ...)

    😕React with 😕1Reacted by Tobias Nießen
13. aduh95 commented on Sep 27, 2023

    

    aduh95

    on Sep 27, 2023

    More actions

    Should we maybe put in the docs, that using a number instead of a string for mode is significantly faster?

    My two cents on this: we should avoid putting performance recommendation in there as it's likely to get outdated without us noticing. We could update the examples to use a constant if they are not already, so it nudges the reader to use the (currently) faster alternative.

    👍React with 👍2Reacted by Vinicius Lourenço and Tobias Nießen
14. CanadaHonk commented on Sep 27, 2023

    

    CanadaHonk

    on Sep 27, 2023

    Member

    More actions

    Related a bit, I noticed we use strings as default flag for some common FS ops, it might be a bit faster to use numbers instead?
15. Uzlopak commented on Sep 27, 2023

    

    Uzlopak

    on Sep 27, 2023

    Contributor

    More actions

    There are two params. flag and mode. I just found test-fs-existssync-false.js where we use '0777' instead of 0o777. This could be changed to avoid the conversion bottleneck.

    What do you refer to?
16. 94 remaining items

    Load more
17. RafaelGSS

    added 2 commits that reference this issue on Dec 15, 2023

    fs: improve error performance of readvSync

    ...

    3f7f3ce

    fs: throw fchownSync error from c++

    ...

    35e8f26
18. UlisesGascon

    added 4 commits that reference this issue on Dec 15, 2023

    fs: improve error performance for `rmdirSync`

    ...

    0d59dda

    fs: improve error perf of sync `lstat`+`fstat`

    ...

    831eff4

    fs: improve error performance for `rmdirSync`

    ...

    f94a24c

    fs: improve error perf of sync `lstat`+`fstat`

    ...

    c160adb
19. UlisesGascon

    added a commit that references this issue on Jan 9, 2024

    fs: improve error perf of sync `lstat`+`fstat`

    ...

    05e25e0
20. anonrig

    removed

    performance-agenda

    on Jan 22, 2024
21. anonrig

    unpinned this issue on Jan 22, 2024
22. richardlau

    added 2 commits that reference this issue on Mar 25, 2024

    fs: improve error performance of readvSync

    ...

    6764f0c

    fs: throw fchownSync error from c++

    ...

    afd5d67
23. debadree25

    added 4 commits that reference this issue on Apr 15, 2024

    fs: improve error performance for `unlinkSync`

    ...

    8bc06eb

    fs: improve error performance for `fdatasyncSync`

    ...

    4b7fc22

    fs: improve error performance for `ftruncateSync`

    ...

    418416a

    fs: improve error performance of writevSync

    ...

    d75f4f9