You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like it can be done with the markdown plugin https://github.com/eslint/eslint-plugin-markdown
I tried it with a --fix locally, but didn't PR anything since I find the "standard" config kind of makes a mess of the code
Roger. I'm new here and just trying to get more context so please bear with me.
So, is there no linting on markdown files at all right now? From the code (and your PR here: https://github.com/nodejs/nodejs.org/pull/2557/files) it looks like there are markdown linting rules in place and linting scripts in package.json. Is this not happening?
Or, is it just the inline javascript within .md files that needs linting? If so any chance you could link me to a specific code block of something that needs linting as an example.
This is issue is for linting JS code in the markdown files. You can search the locale files for the following:
```js
#or
```javascript
There are hundreds of instances. Ideally we should use the same linting used in the main repo so that we are consistent, so this might need to be done along with #2523
So am I understanding correctly that there are still more linting rules from the node repo that should be implemented in this repo? I made the (probably faulty) assumption that this was the last step since this is the only remaining issue referenced in #2523. The rest are merged PRs.
TBH, I'm not aware of the internals in the upstream repo. I know they use eslint while here we use standard, which is also using eslint under the hood.
I see, so it sounds like #2523 should be figured out before there's any movement on this one. Maybe I should move conversation over there to try to get some context on that?
Thanks, and just to clarify, this issue and #2523 won't be made moot with the website redesign, yeah?
They might be, but to be honest, it's not clear to me that @nodejs/website-redesign hasn't completely stalled. It might be unlikely to ever complete. Judging from https://github.com/nodejs/nodejs.dev/tree/master/meetings, they haven't had a meeting in almost six months.
(If that initiative is still going, great! But if not, my favored Plan B would be to iterate on this site and ditch the idea of a full-blown redesign and re-launch. No opposition to a full redesign. But I don't want something that's not going to happen to end up discouraging work here that could be valuable.)
Activity
nschonni commentedon Oct 17, 2019
Looks like it can be done with the markdown plugin https://github.com/eslint/eslint-plugin-markdown
I tried it with a --fix locally, but didn't PR anything since I find the "standard" config kind of makes a mess of the code
XhmikosR commentedon Oct 17, 2019
Yup, this should go after #2523
carterbancroft commentedon Jan 14, 2020
What's the status of this issue, is it still something that needs to be worked on?
If so, can you share an example or two of what needs linting?
XhmikosR commentedon Jan 14, 2020
IMO yeah. Every .md file needs to be linted.
carterbancroft commentedon Jan 14, 2020
Roger. I'm new here and just trying to get more context so please bear with me.
So, is there no linting on markdown files at all right now? From the code (and your PR here: https://github.com/nodejs/nodejs.org/pull/2557/files) it looks like there are markdown linting rules in place and linting scripts in package.json. Is this not happening?
Or, is it just the inline javascript within .md files that needs linting? If so any chance you could link me to a specific code block of something that needs linting as an example.
XhmikosR commentedon Jan 14, 2020
This is issue is for linting JS code in the markdown files. You can search the locale files for the following:
There are hundreds of instances. Ideally we should use the same linting used in the main repo so that we are consistent, so this might need to be done along with #2523
carterbancroft commentedon Jan 14, 2020
OK gotcha, thanks.
So am I understanding correctly that there are still more linting rules from the node repo that should be implemented in this repo? I made the (probably faulty) assumption that this was the last step since this is the only remaining issue referenced in #2523. The rest are merged PRs.
XhmikosR commentedon Jan 14, 2020
TBH, I'm not aware of the internals in the upstream repo. I know they use eslint while here we use standard, which is also using eslint under the hood.
carterbancroft commentedon Jan 14, 2020
I see, so it sounds like #2523 should be figured out before there's any movement on this one. Maybe I should move conversation over there to try to get some context on that?
XhmikosR commentedon Jan 14, 2020
Not sure which one should be tackled first.
/CC @Trott @MylesBorins
Trott commentedon Jan 15, 2020
I don't know that it matters which one is done first, although I guess I'd default to doing #2523 first.
carterbancroft commentedon Jan 15, 2020
Thanks, and just to clarify, this issue and #2523 won't be made moot with the website redesign, yeah?
Trott commentedon Jan 15, 2020
They might be, but to be honest, it's not clear to me that @nodejs/website-redesign hasn't completely stalled. It might be unlikely to ever complete. Judging from https://github.com/nodejs/nodejs.dev/tree/master/meetings, they haven't had a meeting in almost six months.
(If that initiative is still going, great! But if not, my favored Plan B would be to iterate on this site and ditch the idea of a full-blown redesign and re-launch. No opposition to a full redesign. But I don't want something that's not going to happen to end up discouraging work here that could be valuable.)
carterbancroft commentedon Jan 16, 2020
Roger that, that makes sense. I don't have much context context here so I appreciate the extra explanation :)
XhmikosR commentedon Dec 19, 2021
This was fixed by @nschonni's #4287