Skip to content

build: warn on incompatible quic configure flags - #66754

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps
Open

aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps

Conversation

@aduh95

@aduh95 aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

We emit similar errors for other configure flags, QUIC is the odd one out where errors are silently swallowed. Those should be turned into errors, but that can be a follow up that we won't backport, while this one should be safe to backport.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Oct 15, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 15, 2026
@aduh95
aduh95 requested a review from jasnell October 15, 2026 14:47
Comment thread configure.py
Comment thread configure.py Outdated
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
   ✖  This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval)
   ✖  GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66754
�[36m⠋�[39m Loading data for nodejs/node/pull/66754
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66754
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66754
�[36m⠋�[39m Getting comments from nodejs/node/pull/66754
�[36m⠋�[39m Getting commits from nodejs/node/pull/66754
✔  Done loading data for nodejs/node/pull/66754
----------------------------------- PR info ------------------------------------
Title      build: warn on incompatible quic configure flags (#66754)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     aduh95:shared-quic-deps -> nodejs:main
Labels     build, author ready, needs-ci, commit-queue, commit-queue-squash, lts-watch-v22.x, lts-watch-v24.x
Commits    2
 - build: warn on incompatible quic configure flags
 - Apply suggestion from @legendecas
Committers 2
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/66754
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66754
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 15 Oct 2026 10:07:52 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/66754#pullrequestreview-5549140275
   ✖  This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval)
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-10-16T14:37:21Z: https://ci.nodejs.org/job/node-test-pull-request/78444/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78444/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78444/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78444/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@aduh95 aduh95 added lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants