Skip to content

test_runner: await building suite before executing - #54155

Closed
EddieAbbondanzio wants to merge 1 commit into
nodejs:mainfrom
EddieAbbondanzio:await-build-before-executing-tests
Closed

EddieAbbondanzio wants to merge 1 commit into
nodejs:mainfrom
EddieAbbondanzio:await-build-before-executing-tests

Conversation

@EddieAbbondanzio

Copy link
Copy Markdown
Contributor

Fixes #54084

Confirmed it fixed the example from the issue:

 ./node --test --test-name-pattern="some test" ../tmp/node-test-fiddles/test.mjs
▶ async describe
  ✔ some test (async) (0.067497ms)
▶ async describe (0.332977ms)
▶ sync describe
  ✔ some test (sync) (0.4713ms)
▶ sync describe (1.160294ms)
ℹ tests 2
ℹ suites 2
ℹ pass 2
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 52.463142

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 1, 2024
@codecov

codecov Bot commented Aug 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (67bc6a4) to head (e9d3b63).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54155      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.01%     
==========================================
  Files         643      643              
  Lines      181580   181590      +10     
  Branches    34894    34897       +3     
==========================================
- Hits       158103   158099       -4     
- Misses      16749    16765      +16     
+ Partials     6728     6726       -2     
Files Coverage Δ
lib/internal/test_runner/test.js 98.10% <100.00%> (+<0.01%) ⬆️

... and 24 files with indirect coverage changes

@pmarchini

Copy link
Copy Markdown
Member

I've tried the proposed fix locally and noticed that many snapshot tests are failing.

e.g. :
image

Could I also suggest adding a specific non-regression test to test-runner-output.mjs?

@EddieAbbondanzio

Copy link
Copy Markdown
Contributor Author

I'm gonna close this since #54011 will have a better fix for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--test-name-pattern not working for async describe suites

3 participants