Skip to content

fix withoutintl builds #41078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 4, 2021
Merged

fix withoutintl builds #41078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tools/doc/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/doc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"node": ">=14.8.0"
},
"devDependencies": {
"highlight.js": "^11.3.1",
"highlight.js": "^11.2.0",

@aduh95 aduh95 Dec 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant to pin the version, right?

Suggested change
"highlight.js": "^11.2.0",
"highlight.js": "11.2.0",

@richardlau richardlau Dec 3, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just partially undid the package updates in #41036. I think the package-lock.json takes care of it as the Makefile runs npm ci:

node/Makefile

Lines 686 to 691 in a257294

tools/doc/node_modules: tools/doc/package.json
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
echo "Skipping tools/doc/node_modules (no crypto)"; \
else \
cd tools/doc && $(call available-node,$(run-npm-ci)) \
fi

@richardlau richardlau Dec 3, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't start failing until #41036 was merged -- the newer highlight.js was published two months ago: https://www.npmjs.com/package/highlight.js

@richardlau richardlau Dec 3, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW https://ci.nodejs.org/job/node-test-commit-linux-containered/29828/nodes=ubuntu1804_sharedlibs_withoutintl_x64/ passed.

"js-yaml": "^4.1.0",
"rehype-raw": "^6.1.0",
"rehype-stringify": "^9.0.2",
Expand Down