Repository navigation
Conversation
Use temp directory for open with `O_DSYNC` (which indicates a write may occur) rather than `fixtures` directory. Additionally, test can be run on macOS so allow that in addition to Linux.
nodejs-github-bot
added
the
test
commented
Dec 21, 2017
Member
Author
commented
Dec 21, 2017
Member
Author
|
Build failure on LinuxONE seems unrelated, re-running: https://ci.nodejs.org/job/node-test-commit-linuxone/11391/ |
cjihrig
approved these changes
Dec 21, 2017
maclover7
approved these changes
Dec 21, 2017
richardlau
approved these changes
Dec 22, 2017
BridgeAR
approved these changes
Dec 22, 2017
gireeshpunathil
approved these changes
Dec 22, 2017
jasnell
approved these changes
Dec 22, 2017
lpinca
approved these changes
Dec 22, 2017
commented
Dec 22, 2017
Member
Author
|
Landed in c339931 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use temp directory for open with
O_DSYNC(which indicates a write mayoccur) rather than
fixturesdirectory. Additionally, test can be runon macOS so allow that in addition to Linux.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs