Assertion failed: (uv__stream_fd(stream) >= 0), function uv_read_start, file ../deps/uv/src/unix/stream.c, line 1477. #987

Activity

1. bnoordhuis commented on Feb 27, 2015

   

   bnoordhuis

   on Feb 27, 2015

   Member

   More actions

   Can you report this to mscdex/node-imap first, please? It might be a bug in that module that flew under the radar until now. If not, @mscdex should holler and I'll reopen the issue. Thanks.
2. bnoordhuis

   closed this as completedon Feb 27, 2015
3. vkurchatkin commented on Feb 27, 2015

   

   vkurchatkin

   on Feb 27, 2015

   Contributor

   More actions

   It looks like node-imap is pure js, so it is probably io.js bug
5. vkurchatkin commented on Feb 27, 2015

   

   vkurchatkin

   on Feb 27, 2015

   Contributor

   More actions

   @gnostic do you have a way to reproduce this issue? what you do reverts libuv/libuv@19d3d50
6. mscdex commented on Feb 27, 2015

   

   mscdex

   on Feb 27, 2015

   Contributor

   More actions

   @bnoordhuis As @vkurchatkin said, imap is pure js, so the error is happening in io.js C++ land.
7. vkurchatkin

   reopened this on Feb 27, 2015
8. sergenikitin commented on Mar 1, 2015

   

   sergenikitin

   on Mar 1, 2015

   Author

   More actions

   io.js v1.4.2 has the same problem.
9. rvagg commented on Mar 1, 2015

   

   rvagg

   on Mar 1, 2015

   Member

   More actions

   @sergenikitin are you on Windows? if so, see #1005 and perhaps #1008 is relevant?
10. sergenikitin commented on Mar 1, 2015

    

    sergenikitin

    on Mar 1, 2015

    Author

    More actions

    @rvagg no, OS X 10.10.2
11. rvagg commented on Mar 1, 2015

    

    rvagg

    on Mar 1, 2015

    Member

    More actions

    /cc @indutny this looks relevant to your stream changes
12. indutny commented on Mar 2, 2015

    

    indutny

    on Mar 2, 2015

    Member

    More actions

    @gnostic does following patch fix the problem for you?

    diff --git a/deps/uv/src/unix/stream.c b/deps/uv/src/unix/stream.c
    index 518a2fc..ade6b90 100644
    --- a/deps/uv/src/unix/stream.c
    +++ b/deps/uv/src/unix/stream.c
    @@ -393,10 +393,13 @@ int uv__stream_open(uv_stream_t* stream, int fd, int flags) {
    
     #if defined(__APPLE__)
       enable = 1;
    -  if (setsockopt(fd, SOL_SOCKET, SO_OOBINLINE, &enable, sizeof(enable)) &&
    -      errno != ENOTSOCK &&
    -      errno != EINVAL) {
    -    return -errno;
    +  if (setsockopt(fd, SOL_SOCKET, SO_OOBINLINE, &enable, sizeof(enable))) {
    +    if (errno != ENOTSOCK &&
    +        errno != EINVAL) {
    +      return -errno;
    +    } else {
    +      errno = 0;
    +    }
       }
     #endif
    
13. sergenikitin commented on Mar 3, 2015

    

    sergenikitin

    on Mar 3, 2015

    Author

    More actions

    @indutny
    I checked this patch, it's not fix the problem. Still have

    Assertion failed: (uv__stream_fd(stream) >= 0), function uv_read_start, file ../deps/uv/src/unix/stream.c, line 1480.
    Abort trap: 6
    
14. indutny commented on Mar 3, 2015

    

    indutny

    on Mar 3, 2015

    Member

    More actions

    @sergenikitin is there any way to reproduce it?
15. indutny commented on Mar 3, 2015

    

    indutny

    on Mar 3, 2015

    Member

    More actions

    Ok, a test case:

    var tls = require('tls');
    var net = require('net');
    
    var socket = new net.Socket();
    
    var s = tls.connect({
      socket: socket,
      servername: 'google.com'
    }, function() {
      console.log('secure');
    });
    
    socket.connect(443, 'google.com');
16. indutny commented on Mar 3, 2015

    

    indutny

    on Mar 3, 2015

    Member

    More actions

    @bnoordhuis @vkurchatkin @rvagg I have two solutions:

    • assume that net.Socket is a JSStream if it has yet no _handle (i.e. .connect() wasn't called)
    • allow adding parent socket handle to TLSSocket after creating it

    The first solution is very easy to implement and should generally get various code like that test case working without any problems, except probably reduced bandwidth.

    The second one is a bit complicated and might take some time to implement.

    What do you think about doing (1) and then (2)?
17. bnoordhuis commented on Mar 3, 2015

    

    bnoordhuis

    on Mar 3, 2015

    Member

    More actions

    @indutny Is what you are proposing in (1) spiritually equivalent to:

    if (!socket._handle) {
      socket.once('connect', function() {
        // continue with tls.connect()?
      });
      return;
    }

    ?
18. indutny

    added a commit that references this issue on Mar 3, 2015

    tls: accept empty `net.Socket`s

    ...

    e471150
19. indutny commented on Mar 3, 2015

    

    indutny

    on Mar 3, 2015

    Member

    More actions

    @bnoordhuis like this #1046
20. indutny

    added a commit that references this issue on Mar 3, 2015

    tls: accept empty `net.Socket`s

    ...

    7b3b8ac
21. Fishrock123

    closed this as completedon Mar 6, 2015
22. Renegade334

    added a commit that references this issue on Jun 21, 2026

    deps: libffi: cherry-pick 9ca53a19833d

    ...

    This issue will close once commit b07e414 is merged into the 'main' branch.

    b07e414
23. aduh95

    added 2 commits that reference this issue on Jun 22, 2026

    deps: libffi: cherry-pick 9ca53a19833d

    ...

    This issue will close once commit e9a9065 is merged into the 'main' branch.

    e9a9065

    deps: libffi: cherry-pick 9ca53a19833d

    ...

    This issue will close once commit bbef54b is merged into the 'main' branch.

    bbef54b