Repository navigation
Buffer.alloc v4: Incorrectly returns zero-filled buffer when encoding is passed #9226
Description
- v4.6.1, 4.5.0, 4.6.0:
- Darwin Kernel Version 16.0.0; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64:
Buffer.alloc(size, data, enc):
$ node
> let s = 'YQ=='
undefined
> Buffer.alloc(s.length, s, 'base64')
<Buffer 00 00 00 00>
> Buffer(s, 'base64')
<Buffer 61>
> Buffer.alloc(1, s, 'base64')
<Buffer 00>
> Buffer(s, 'base64').toString('base64')
'YQ=='
> let b = Buffer(s.length); b.write(s, 'base64'); b
<Buffer 61 00 00 00>
> b.toString('base64')
'YQAAAA=='Also, the Buffer.alloc(size, data, enc) docs example fails:
> Buffer.alloc(11, 'aGVsbG8gd29ybGQ=', 'base64');
<Buffer 00 00 00 00 00 00 00 00 00 00 00>
Activity
mscdex commentedon Oct 21, 2016
/cc @nodejs/buffer
not-an-aardvark commentedon Oct 22, 2016
Working on this. The issue is that
Buffer.alloccallsBuffer.fillwith anotherBufferas an argument. However, passing anotherBufferas an argument is not supported in Node 4.ChALkeR commentedon Oct 23, 2016
Ow, that was my backport. Btw, it probably means that there is no testcase for that in
master, if it wasn't added recently, as I backported with testcases. Will take a look at that.ChALkeR commentedon Oct 23, 2016
Update: the coverage was recently (2016-09-19) fixed in master in 8699ecd (#8552). That probably needs to be backported to v4.x.
MylesBorins commentedon Oct 25, 2016
@ChALkeR would you be able to do a Pr?
On Sun, Oct 23, 2016, 10:45 AM Сковорода Никита Андреевич <
notifications@github.com> wrote:
ChALkeR commentedon Oct 25, 2016
@thealphanerd You mean the testcases update? I will take a look at that.
buffer: fix `fill` with encoding in Buffer.alloc()
MylesBorins commentedon Oct 26, 2016
fixed in dc3e45f and will land in v4.6.2
buffer: fix `fill` with encoding in Buffer.alloc()