Skip to content

repl: error thrown while writing function statement in '.editor' mode #9189

Closed
Closed
repl: error thrown while writing function statement in '.editor' mode#9189
Labels
replIssues and PRs related to the REPL subsystem.windowsIssues and PRs related to the Windows platform.

Description

@jcpst
jcpst
opened on Oct 19, 2016
  • Version: 6.9.0
  • Platform: 64-bit windows 10

When using the REPL's .editor mode, the following error occurs when hitting the 'ENTER' key after a return statement. Tested in both CMD and Git Bash

C:\Users\joe>node -v
v6.9.0

C:\Users\joe>node
> var a = 1
undefined
> .editor
// Entering editor mode (^D to finish, ^C to cancel)
function thing (x) {
  return x
readline.js:982
            throw err;
            ^

Error: write EPIPE
    at exports._errnoException (util.js:1026:11)
    at ReadStream.Socket._writeGeneric (net.js:710:26)
    at ReadStream.Socket._write (net.js:729:8)
    at doWrite (_stream_writable.js:333:12)
    at writeOrBuffer (_stream_writable.js:319:5)
    at ReadStream.Writable.write (_stream_writable.js:246:11)
    at ReadStream.Socket.write (net.js:656:40)
    at REPLServer.<anonymous> (repl.js:479:26)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:188:7)

Activity

  1. cjihrig commented on Oct 19, 2016

    @cjihrig
    cjihrig
    on Oct 19, 2016
    Contributor

    cc: @princejwesley

  2. princejwesley commented on Oct 19, 2016

    @princejwesley
    princejwesley
    on Oct 19, 2016
    Contributor

    Works fine in macOS. I'll try this in windows 10.

  3. mscdex
    added
    replIssues and PRs related to the REPL subsystem.
    windowsIssues and PRs related to the Windows platform.
    on Oct 19, 2016

  4. princejwesley commented on Oct 19, 2016

    @princejwesley
    princejwesley
    on Oct 19, 2016
    Contributor

    Works fine in v6.5.0(irrelevant). Writing white spaces to input stream throws this error in v6.9.0.

    Update: Pipe is closed when write to input stream (#8241). Disable auto alignment feature in windows will fix this issue.

  5. princejwesley commented on Oct 20, 2016

    @princejwesley
    princejwesley
    on Oct 20, 2016
    Contributor

    @addaleax @Fishrock123 Thinking of protecting input stream from writing with inputStream.isTTY && (inputStream.writable || process.platform !== 'win32') predicate. Any suggestion?

  6. addaleax commented on Oct 20, 2016

    @addaleax
    addaleax
    on Oct 20, 2016
    Member

    Hm, why does the REPL try to write to the input stream here in the first place? Is there any reason not to use the output stream for that?

  7. princejwesley commented on Oct 20, 2016

    @princejwesley
    princejwesley
    on Oct 20, 2016
    Contributor

    @addaleax User can use backspace to remove/adjust the alignment.

  8. addaleax commented on Oct 20, 2016

    @addaleax
    addaleax
    on Oct 20, 2016
    Member

    @princejwesley I’m not sure if I’m unaware of something Windows-specific here, but generally, that should work fine when writing to the output stream?

  9. princejwesley commented on Oct 20, 2016

    @princejwesley
    princejwesley
    on Oct 20, 2016
    Contributor

    @addaleax can we undo the characters written to output stream? In the case of input stream, current line data is still in buffer and user can use backspace to erase white spaces added for alignment

    My understanding is, output stream is read only in ttys perspective.

  10. addaleax commented on Oct 20, 2016

    @addaleax
    addaleax
    on Oct 20, 2016
    Member

    current line data is still in buffer

    Whose buffer? In the context of the REPL, the TTY is generally in raw mode, so buffering is not really an issue here, and the current line is only stored by our readline.Interface instance.

    So, yeah, you’re right, we shouldn’t directly write to the output stream, but call the readline write(). Something like this seems like a correct patch to me:

    diff --git a/lib/repl.js b/lib/repl.js
index 620addc5ef53..283adfeb78be 100644
--- a/lib/repl.js
+++ b/lib/repl.js
@@ -476,7 +476,7 @@ function REPLServer(prompt,
       const matches = self._sawKeyPress ? cmd.match(/^\s+/) : null;
       if (matches) {
         const prefix = matches[0];
-        self.inputStream.write(prefix);
+        self.write(prefix);
         self.line = prefix;
         self.cursor = prefix.length;
       }
@@ -601,6 +601,7 @@ function REPLServer(prompt,
   // Wrap readline tty to enable editor mode
   const ttyWrite = self._ttyWrite.bind(self);
   self._ttyWrite = (d, key) => {
+    key = key || {};
     if (!self.editorMode || !self.terminal) {
       ttyWrite(d, key);
       return;

    That last piece should probably be added anyway, too, to match the check in readline.js.

    What do you think?

  11. princejwesley commented on Oct 20, 2016

    @princejwesley
    princejwesley
    on Oct 20, 2016
    Contributor

    @addaleax Yea, its perfect 👍

  12. addaleax commented on Oct 20, 2016

    @addaleax
    addaleax
    on Oct 20, 2016
    Member

    Okay, I’ll PR with that then :)

  13. addaleax
    closed this as completedin 3dfc127on Oct 26, 2016
  14. evanlucas
    added a commit that references this issue on Nov 3, 2016

    repl: don’t write to input stream in editor mode

    0b9d80a
  15. MylesBorins
    added a commit that references this issue on Nov 22, 2016

    repl: don’t write to input stream in editor mode

    58b60fc
  16. sjarmak
    added a commit that references this issue on Jul 27, 2026

    repl: don’t write to input stream in editor mode

    3dfc127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    replIssues and PRs related to the REPL subsystem.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions