Skip to content

FreeBSD failures on v4.x #9013

Closed
Closed
FreeBSD failures on v4.x#9013
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.freebsdIssues and PRs related to the FreeBSD platform.

Description

@MylesBorins
MylesBorins
opened on Oct 10, 2016

This is a very odd one parallel/test-child-process-uid-gid started failing today when I was testing v4.x.

This test has not failed in the past, but is now failing the current head of v4.x-staging, v4.6.0, and v4.5.0

I am unsure if this is an env issue or not... I have attempted to ssh into one of our BSD machines, manually compile and test, and see no failures.

I've also attempted to manually in the artifact directory that jenkins used both with the commands

$ ./node test/parallel/test-child-process-uid-gid.js

and

$ python tools/test.py parallel/test-child-process-uid-gid

neither of these attempts fail either.

Activity

  1. MylesBorins
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    v4.x
    on Oct 10, 2016
  2. mscdex
    added
    freebsdIssues and PRs related to the FreeBSD platform.
    on Oct 10, 2016

  3. MylesBorins commented on Oct 10, 2016

    @MylesBorins
    MylesBorins
    on Oct 10, 2016
    ContributorAuthor

    /cc @nodejs/platform-freebsd

  4. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    Logs?

  5. MylesBorins commented on Oct 10, 2016

    @MylesBorins
    MylesBorins
    on Oct 10, 2016
    ContributorAuthor

    https://ci.nodejs.org/job/node-test-commit-freebsd/4728/nodes=freebsd10-64/tapTestReport/test.tap-81/

    not ok 81 parallel/test-child-process-uid-gid
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: Missing expected exception..
# at _throws (assert.js:337:5)
# at Function.assert.throws (assert.js:361:3)
# at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-child-process-uid-gid.js:8:8)
# at Module._compile (module.js:409:26)
# at Object.Module._extensions..js (module.js:416:10)
# at Module.load (module.js:343:32)
# at Function.Module._load (module.js:300:12)
# at Function.Module.runMain (module.js:441:10)
# at startup (node.js:139:18)
# at node.js:974:3

  6. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    Thanks!

  7. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    That's:

    spawn('echo', ['fhqwhgads'], {uid: 0})

    That is expected to throw EPERM.

  8. MylesBorins commented on Oct 10, 2016

    @MylesBorins
    MylesBorins
    on Oct 10, 2016
    ContributorAuthor

    the error is that it isn't throwing
    ¯_(ツ)_/¯

  9. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @thealphanerd oh, I was just stating what happens in test. Sorry!

  10. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @thealphanerd is it running under root (or superuser)? Is it running in jail?

  11. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @thealphanerd what is the output of sysctl security.bsd.suser_enabled?

  12. MylesBorins commented on Oct 10, 2016

    @MylesBorins
    MylesBorins
    on Oct 10, 2016
    ContributorAuthor

    when I was manually running it security.bsd.suser_enabled: 1

    @jbergstroem may know more about how things are setup during CI

  13. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @jbergstroem I wonder if this box may be running tests with effective user id set to 0?

  14. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @thealphanerd thanks!

  15. indutny commented on Oct 10, 2016

    @indutny
    indutny
    on Oct 10, 2016
    Member

    @jbergstroem further question, do we use https://www.freebsd.org/doc/handbook/mac.html ?

  16. jbergstroem commented on Oct 10, 2016

    @jbergstroem
    jbergstroem
    on Oct 10, 2016
    Member

    @indutny no, we run as regular user:

    $ id
uid=1002(iojs) gid=1002(iojs) groups=1002(iojs)

    re mac: this is stock freebsd 10.3p9 -- I recall mac modules being optional so I'd say no.

  17. MylesBorins
    added a commit that references this issue on Oct 24, 2016

    test: mark test-child-process-uid-gid as flaky

    bae182e

  18. targos commented on Jan 8, 2017

    @targos
    targos
    on Jan 8, 2017
    Member

    @MylesBorins is this fixed?

  19. MylesBorins commented on Jan 9, 2017

    @MylesBorins
    MylesBorins
    on Jan 9, 2017
    ContributorAuthor

    yup

  20. MylesBorins
    closed this as completedon Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.freebsdIssues and PRs related to the FreeBSD platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions