Skip to content

stream, test: Add test for _writableState clearBuffer state machine #8687

Closed

Description

@mcollina
  • Version: all
  • Platform: all
  • Subsystem: stream, test

Part of #8644

Add tests for:

stream._writableState.corked
stream._writableState.bufferedRequestCount

function clearBuffer(stream, state) {

// when true all writes will be buffered until .uncork() call
this.corked = 0;

// count buffered requests
this.bufferedRequestCount = 0;

cc @Fishrock123 @nodejs/streams

Activity

  1. ghost added
    streamIssues and PRs related to Node.js streams.
    on Sep 21, 2016
  2. ghost added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Sep 21, 2016
  3. ghost added
    good first issueIssues that are suitable for first-time contributors.
    on Sep 21, 2016
  4. ghost added a commit that references this issue on Jan 2, 2017
  5. ghost closed this as completedon Jan 3, 2017
  6. ghost added a commit that references this issue on Jan 4, 2017
  7. ghost added a commit that references this issue on Jan 23, 2017
  8. ghost added a commit that references this issue on Jan 23, 2017
  9. ghost added a commit that references this issue on Jan 23, 2017
  10. 1 remaining item

  11. ghost added a commit that references this issue on Jan 24, 2017
  12. ghost added a commit that references this issue on Jan 24, 2017
  13. ghost added a commit that references this issue on Jan 31, 2017
  14. ghost added a commit that references this issue on Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.streamIssues and PRs related to Node.js streams.testIssues and PRs related to Node.js core tests and test infrastructure.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions