Repository navigation
punycode: remove the module system detection from punycode.js #7401
Description
- Version: latest
- Platform: any
- Subsystem: punycode
lib/punycode.js looks more like the dependency required by the core module url, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.
So I propose the following:
- add a deps directory in
./libdirectory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend) - update the punycode source file to be the CMD way just like other
.jsfiles, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.
Activity
yorkie commentedon Jun 24, 2016
Sorry, make a noise issue because of bad networking, closed.
Fishrock123 commentedon Jun 24, 2016
I closed the other. :)
yorkie commentedon Jun 24, 2016
Ah Thank you @Fishrock123
yorkie commentedon Jun 24, 2016
cc @mathiasbynens, the author of the current punycode.js :-)
silverwind commentedon Jun 25, 2016
Why not move it to
deps? That way, we could also remove the exception in.eslintignore. I'm not oposed to rewriting (and reducing) the code in there itself, but we have to keep in mind that updating it will be a lot less straight-forward.yorkie commentedon Jun 26, 2016
Not putting it into
depsjust because it's a pure library in pure JavaScript, so it should be loaded in runtime, not the compiling time. This is that the differences.jasnell commentedon Aug 1, 2016
Recommend closing this given the decision to deprecate the punycode module bundled in core. See: #7941
yorkie commentedon Aug 1, 2016
Closing this as @jasnell's recommendation :-)