Activity

1. bnoordhuis commented on Apr 20, 2016

   

   bnoordhuis

   on Apr 20, 2016

   Member

   More actions

   Quoting the relevant part:

   curl -v "http://localhost:5555?test=1 2"

   That makes curl send an invalid HTTP request. To wit:

   $ strace -s 1024 -e sendto curl "http://localhost:5555?test=1 2"
   sendto(3, "GET /?test=1 2 HTTP/1.1\r\nHost: localhost:5555\r\nUser-Agent: curl/7.43.0\r\nAccept: */*\r\n\r\n", 87, MSG_NOSIGNAL, NULL, 0) = 87
   curl: (52) Empty reply from server
   +++ exited with 52 +++
   

   The salient part is the request line - GET /?test=1 2 HTTP/1.1\r\n - which is clearly malformed.

   Closing, not a bug in node.js.
2. bnoordhuis

   closed this as completedon Apr 20, 2016
3. bnoordhuis

   added

   invalidIssues and PRs that are invalid.Issues and PRs that are invalid.

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   on Apr 20, 2016
4. alekzonder commented on Apr 20, 2016

   

   alekzonder

   on Apr 20, 2016

   Last edited by alekzonder

   Author

   More actions

   @bnoordhuis But why in Golang or Python i got "400 Bad Request" for unencoded space in GET-param value?

   golang

   server.go

   package main
   
   import (
       "fmt"
       "net/http"
   )
   
   func handler(w http.ResponseWriter, r *http.Request) {
       fmt.Fprintf(w, "Hello World")
   }
   
   func main() {
       http.HandleFunc("/", handler)
       http.ListenAndServe(":5555", nil)
   }

   curl

   $ curl -v "http://localhost:5555?asd=asd asd"
   * Rebuilt URL to: http://localhost:5555/?asd=asd asd
   *   Trying ::1...
   * Connected to localhost (::1) port 5555 (#0)
   > GET /?asd=asd asd HTTP/1.1
   > Host: localhost:5555
   > User-Agent: curl/7.43.0
   > Accept: */*
   >
   < HTTP/1.1 400 Bad Request
   * no chunk, no close, no size. Assume close to signal end
   <
   * Closing connection 0
   

   python

   server.py

   #!/usr/bin/python
   from BaseHTTPServer import BaseHTTPRequestHandler,HTTPServer
   
   PORT_NUMBER = 5555
   
   class myHandler(BaseHTTPRequestHandler):
   
       def do_GET(self):
           self.send_response(200)
           self.send_header('Content-type','text/html')
           self.end_headers()
           self.wfile.write("Hello World !")
           return
   
   try:
       server = HTTPServer(('', PORT_NUMBER), myHandler)
       print 'Started httpserver on port ' , PORT_NUMBER
       server.serve_forever()
   
   except KeyboardInterrupt:
       print '^C received, shutting down the web server'
       server.socket.close()

   curl

    curl -v "http://localhost:5555?asd=asd asd"
   * Rebuilt URL to: http://localhost:5555/?asd=asd asd
   *   Trying ::1...
   * connect to ::1 port 5555 failed: Connection refused
   *   Trying fe80::1...
   * connect to fe80::1 port 5555 failed: Connection refused
   *   Trying 127.0.0.1...
   * Connected to localhost (127.0.0.1) port 5555 (#0)
   > GET /?asd=asd asd HTTP/1.1
   > Host: localhost:5555
   > User-Agent: curl/7.43.0
   > Accept: */*
   >
   <head>
   <title>Error response</title>
   </head>
   <body>
   <h1>Error response</h1>
   <p>Error code 400.
   <p>Message: Bad request syntax ('GET /?asd=asd asd HTTP/1.1').
   <p>Error code explanation: 400 = Bad request syntax or unsupported method.
   </body>
   * Connection #0 to host localhost left intact
   

   in node.js no response at all

   $ curl -v "http://localhost:5555?asd=asd asd"
   * Rebuilt URL to: http://localhost:5555/?asd=asd asd
   *   Trying ::1...
   * Connected to localhost (::1) port 5555 (#0)
   > GET /?asd=asd asd HTTP/1.1
   > Host: localhost:5555
   > User-Agent: curl/7.43.0
   > Accept: */*
   >
   * Empty reply from server
   * Connection #0 to host localhost left intact
   curl: (52) Empty reply from server```
   
5. bnoordhuis commented on Apr 20, 2016

   

   bnoordhuis

   on Apr 20, 2016

   Member

   More actions

   You can send a 400 response if you want but node doesn't do it by default:

   http.createServer(...).listen(port).on('clientError', (err, conn) => {
     console.error(err);
     conn.end(
         'HTTP/1.1 400 Bad Request\r\n' +
         'Content-Length: 0\r\n' +
         '\r\n');
   });

   👍React with 👍5Reacted by alekzonder, Don, huacong, xiaojue and shenuu
6. cristianbote commented on Feb 2, 2018

   

   cristianbote

   on Feb 2, 2018

   More actions

   FYI, if somebody else is stumbling over this, it has been taken care of here #15324

   👍React with 👍4Reacted by alekzonder, Maxim Chvertkin, Johan and Chaitanya Surapaneni
7. atefBB commented on Sep 5, 2019

   

   atefBB

   on Sep 5, 2019

   More actions

   @cristianbote Any ideas to solve this issue?
   I don't understand the content in the link #15324 !