Add a label to note “this is good for CI” #62496

Activity

1. jasnell commented on Mar 29, 2026

   

   jasnell

   on Mar 29, 2026

   Member

   More actions

   For this I would usually just launch the ci job manually.

   👍React with 👍1Reacted by Luigi Pinca
2. panva commented on Mar 29, 2026

   

   panva

   on Mar 29, 2026

   Last edited by panva

   Member

   More actions

   If you can be bothered to do this from a console

   request-ci () {
   	if [ $# -eq 0 ]
   	then
   		echo "Usage: request-ci <PR_NUMBER>"
   		echo "Example: request-ci 123"
   		return 1
   	fi
   	local pr_number=$1 
   	echo "Getting last commit SHA for PR #${pr_number}..."
   	local last_commit_sha=$(gh pr view $pr_number --json commits --jq '.commits[-1].oid') 
   	if [ -z "$last_commit_sha" ]
   	then
   		echo "Error: Could not retrieve commit SHA for PR #${pr_number}"
   		return 1
   	fi
   	echo "Last commit SHA: $last_commit_sha"
   	echo "About to run: ncu-ci run $pr_number --certify-safe $last_commit_sha"
   	echo -n "Do you want to proceed? (y/N): "
   	read -r confirmation
   	if [[ "$confirmation" =~ ^[Yy]$ ]]
   	then
   		echo "Running CI..."
   		ncu-ci run $pr_number --certify-safe $last_commit_sha
   	else
   		echo "CI request cancelled."
   		return 0
   	fi
   }
3. joyeecheung commented on Mar 30, 2026

   

   joyeecheung

   on Mar 30, 2026

   Member

   More actions

   I think I suggested somewhere in https://github.com/nodejs/node-core-utils/issues that we could just allow it in the CI if the commit to test was pushed by a collaborator. In any case the logic needs to happen in there..

   ❤️React with ❤️1Reacted by Matteo Collina
4. aduh95 commented on Mar 30, 2026

   

   aduh95

   on Mar 30, 2026

   Contributor

   More actions

   To start a CI from the CLI, ncu-ci run <url-of-the-commit-to-test> does the job, e.g. ncu-ci run https://github.com/nodejs/node/pull/62379/commits/ccc837f89e282530e44348d5e6ec3f32058fcd44
5. aduh95 commented on Mar 30, 2026

   

   aduh95

   on Mar 30, 2026

   Last edited by aduh95

   Contributor

   More actions

   Is it possible to improve our automation to know on which commit the request-ci label was applied to

   No it's not possible, GH API does not give us that information.

   In nodejs/node-core-utils#920, I have worked on making it work by parsing comments (so if a collaborator comments @nodejs-github-bot test ccc837f89e282530e44348d5e6ec3f32058fcd44, the CI would know to trust that commit), but it's actually more work for the collaborator than using the CLI, and using GH comments is not very elegant (sends notifications to everyone subscribed, can be edited, no auto-complete so easy to mess up syntax, etc)
6. aduh95 commented on Mar 31, 2026

   

   aduh95

   on Mar 31, 2026

   Contributor

   More actions

   I've opened #62524 which should already improve the UX
7. mcollina

   closed this as not plannedon Mar 31, 2026
8. aduh95

   added a commit that references this issue on Apr 2, 2026

   tools: allow triagers to queue a PR for CI until it's reviewed

   ...

   25443db
9. aduh95

   closed this as completedin #62524on Apr 2, 2026
10. aduh95

    added 2 commits that reference this issue on May 5, 2026

    tools: allow triagers to queue a PR for CI until it's reviewed

    ...

    e2ba824

    tools: allow triagers to queue a PR for CI until it's reviewed

    ...

    1fee265
11. marco-ippolito

    added a commit that references this issue on Jul 29, 2026

    tools: allow triagers to queue a PR for CI until it's reviewed

    ...

    1118f1f