Repository navigation
Certain kinds of HTTPS requests hang due to a race condition around reused sockets #60001
Description
Version
22.20.0
Platform
Darwin AQ5T24P47N6 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:29 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T6000 arm64
Subsystem
https
What steps will reproduce the bug?
See https://github.com/martinslota/node-socket-reuse-race for a detailed description and a script that shows the situation in which HTTPS client requests hang.
How often does it reproduce? Is there a required condition?
I can reproduce it every single time (on my machine).
What is the expected behavior? Why is that the expected behavior?
I expect the script in https://github.com/martinslota/node-socket-reuse-race to be able to run almost indefinitely.
What do you see instead?
The script fails.
Additional information
This bug report is a result of investigating aws/aws-sdk-js-v3#6426.
Activity
bakkot commentedon Sep 24, 2025
Drive-by: https://github.com/martinslota/node-socket-reuse-race 404s for me; possibly it's private?
martinslota commentedon Sep 24, 2025
Apologies, should be fixed now.
martinslota commentedon Sep 30, 2025
I ran a
git bisecton thev19.xbranch (because I can only reproduce the issue from Node 19 onwards) and it blames #43902 for this issue.Fix aws#6426: S3 commands hang after uploading an empty stream
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish
http: fix keep-alive socket reuse race in requestOnFinish