client-proxy/test-https-proxy-request-invalid-char-in-url is flaky

Reason	`client-proxy/test-https-proxy-request-invalid-char-in-url`
Type	JS_TEST_FAILURE
Failed PR	3 (https://github.com/nodejs/node/pull/59587/, https://github.com/nodejs/node/pull/59734/, https://github.com/nodejs/node/pull/59717/)
Appeared	vm-efv4j, vm-a49f1, vm-yy37e
First CI	https://ci.nodejs.org/job/node-test-pull-request/68946/
Last CI	https://ci.nodejs.org/job/node-test-pull-request/69014/

Example

not ok 4333 client-proxy/test-https-proxy-request-invalid-char-in-url
  ---
  duration_ms: 413.52500
  severity: fail
  exitcode: 1
  stack: |-
    #6 eneded response for: 'https://local\rhost:55386/carriage-return-in-host'
    #5 eneded response for: 'https://local\r\nhost:55386/crlf-in-host'
    #4 eneded response for: 'https://local\nhost:55386/newline-in-host'
    #3 eneded response for: 'https://localhost:5\r5386/carriage-return-in-port'
    #2 eneded response for: 'https://localhost:5\n5386/newline-in-port'
    #1 eneded response for: 'https://localhost:5\r\n5386/crlf-in-port'
    node:assert:147
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    + actual - expected
    
    + Set(8) {
    - Set(6) {
        {
    +     error: Error [ERR_STREAM_WRITE_AFTER_END]: write after end
    +         at _write (node:internal/streams/writable:487:11)
    +         at Writable.write (node:internal/streams/writable:508:10)
    +      ...

From https://github.com/nodejs/reliability/blob/main/reports/2025-09-03.md

test: guard write to proxy client if proxy connection is ended

This occasionally still show up in the CI with this additional error: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md

      {
        error: Error: This socket has been ended by the other party
            at genericNodeError (node:internal/errors:998:15)
            at wrappedFn (node:internal/errors:543:14)
            at Socket.writeAfterFIN [as write] (node:net:575:14)
            at Socket.ondata (node:internal/streams/readable:1008:24)
            at Socket.emit (node:events:508:28)
            at addChunk (node:internal/streams/readable:559:12)
            at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
            at Readable.push (node:internal/streams/readable:390:5)
            at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
          code: 'EPIPE'
        },
        source: 'proxy connect'
      }

Opened #60269 to ignore those errors - I don't think we care for the purpose of this test.

test: ignore EPIPE errors in https proxy invalid URL test

Navigation Menu

Repository navigation

client-proxy/test-https-proxy-request-invalid-char-in-url is flaky #59741

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

client-proxy/test-https-proxy-request-invalid-char-in-url is flaky #59741

Description

Activity

joyeecheung commented on Oct 15, 2025

joyeecheung commented on Oct 15, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions