Unflag --experimental-webstorage

I think we could start shipping with localStorage enabled by default in v25.

@cjihrig

SGTM

Hey, could you give some guidance on what needs to be done to unflag --experimental-webstorage? I tried setting this option as the default in node_options.cc and node_options.h as shown in the diff:

diff --git a/src/node_options.cc b/src/node_options.cc
index 16cce0df0e..d30b0b87b6 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -456,7 +456,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
   AddOption("--experimental-webstorage",
             "experimental Web Storage API",
             &EnvironmentOptions::experimental_webstorage,
-            kAllowedInEnvvar);
+            kAllowedInEnvvar,
+            true);
   AddOption("--localstorage-file",
             "file used to persist localStorage data",
             &EnvironmentOptions::localstorage_file,
diff --git a/src/node_options.h b/src/node_options.h
index baa615e310..07cda97d71 100644
--- a/src/node_options.h
+++ b/src/node_options.h
@@ -126,7 +126,7 @@ class EnvironmentOptions : public Options {
   bool experimental_fetch = true;
   bool experimental_websocket = true;
   bool experimental_sqlite = true;
-  bool experimental_webstorage = false;
+  bool experimental_webstorage = true;
 #ifdef NODE_OPENSSL_HAS_QUIC
   bool experimental_quic = false;
 #endif

This change works when running node directly:

But the tests in test/parallel/test-webstorage.js are failing and I'm not sure why. I'd appreciate it if you could give me a hint on what I'm missing, thanks!

EDIT:

The tests fail with the following error:

node:internal/webstorage:30
          throw new ERR_INVALID_ARG_VALUE('--localstorage-file',
          ^

TypeError [ERR_INVALID_ARG_VALUE]: The argument '--localstorage-file' is an invalid localStorage location. Received ''
    at Object.get [as localStorage] (node:internal/webstorage:30:17)
    at get localStorage (node:internal/util:629:20)
    at /home/daniel/open_source/node/test/common/index.js:318:17
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/daniel/open_source/node/test/common/index.js:317:3)
    at Module._compile (node:internal/modules/cjs/loader:1734:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1899:10)
    at Module.load (node:internal/modules/cjs/loader:1469:32)
    at Module._load (node:internal/modules/cjs/loader:1286:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14) {
  code: 'ERR_INVALID_ARG_VALUE'
}

Node.js v24.0.0-pre

Probably there is something else to fix.

Can you push what you have in a draft PR?

In test/common/index.js it adds localStorage to the globalThis, but this requires the localStorage file.

seems like it has the same effect as ./node -e 'localStorage'

@mcollina

Can you push what you have in a draft PR?

@mcollina That's been pushed (#57666)

webstorage: unflag --experimental-webstorage

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Issues and PRs exempt from automated stale handling. label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

global-client: fix unit tests on Node 25+

fix(web-inspector): make jsdom own localStorage cleanly on Node 25+

Navigation Menu

Repository navigation

Unflag --experimental-webstorage #57658

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Unflag --experimental-webstorage #57658

Description

Activity

mcollina commented on Mar 28, 2025

cjihrig commented on Mar 28, 2025

danielmbrasil commented on Mar 28, 2025

mcollina commented on Mar 28, 2025

mcollina commented on Mar 28, 2025

geeksilva97 commented on Mar 28, 2025

danielmbrasil commented on Mar 28, 2025

github-actions commented on Sep 25, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions