Repository navigation
DOMException should have [[ErrorData]] internal slot #56497
Description
Version
N/A
Platform
N/A
Subsystem
N/A
What steps will reproduce the bug?
This bug has not surfaced yet, but when V8 implements Error.isError, it should return true for DOMException.
Error.isError(new DOMException(1)) // => false, true expectedHow often does it reproduce? Is there a required condition?
Not yet.
What is the expected behavior? Why is that the expected behavior?
Due to a change in Web IDL.
whatwg/webidl#1421
What do you see instead?
Not yet.
Additional information
This issue can be resolved by using Reflect.construct.
denoland/deno#27342
As a side effect, util.types.isNativeError will return true as well.
Activity
[-]DONException should have `[[ErrorData]]` internal slot[/-][+]`DONException` should have `[[ErrorData]]` internal slot[/+]ljharb commentedon Jan 7, 2025
A simple way to do this might be making
node/lib/internal/per_context/domexception.js
Line 51 in 062ae6f
[-]`DONException` should have `[[ErrorData]]` internal slot[/-][+]`DOMException` should have `[[ErrorData]]` internal slot[/+]petamoriken commentedon Jan 7, 2025
I tried to implement inheriting
Errorin Deno, but it caused WPT fails.https://github.com/web-platform-tests/wpt/blob/5799f5b24761cff805f20e5ec130bf3cb328e4ed/webidl/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.js#L13-L15
ljharb commentedon Jan 7, 2025
@petamoriken indeed you'd have to
Object.setPrototypeOf(DOMException.prototype, Function.prototype)or something as well.zloirock commentedon May 3, 2025
V8 is updated to 13.6 with shipped
Error.isError, this issue is not fixed, stable Node 24 is planned in some days.Amirali-Amirifar commentedon May 3, 2025
Related to #40789
Error.isErrordoes not properly works withDOMException#58134 as a duplicate of this issueError.isError does not work for DOMException in node24
Updates for Node.js 24.0 (#26735)
lib: make domexception a native error
deps: V8: cherry-pick e3df60f3f5ab
deps: V8: cherry-pick e3df60f3f5ab
lib: make domexception a native error
deps: V8: cherry-pick e3df60f3f5ab
lib: make domexception a native error