Repository navigation
Build: --fully-static is broken with 23.5.0 #56347
Description
Version
23.5.0
Platform
Running docker amd64 on AWS Fargate
Subsystem
No response
What steps will reproduce the bug?
./configure --fully-static --enable-static
make "-j4"How often does it reproduce? Is there a required condition?
No, it just fails for that version, other versions are still fine.
What is the expected behavior? Why is that the expected behavior?
It should successfully build a node binary.
What do you see instead?
... lines before
In member function 'icu_76::Calendar& icu_76::Calendar::operator=(const icu_76::Calendar&)',
inlined from 'icu_76::Calendar& icu_76::Calendar::operator=(const icu_76::Calendar&)' at ../deps/icu-small/source/i18n/calendar.cpp:805:1:
../deps/icu-small/source/common/cstring.h:43:70: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying 156 bytes from a string of length 156 [-Wstringop-truncation]
43 | #define uprv_strncpy(dst, src, size) U_STANDARD_CPP_NAMESPACE strncpy(dst, src, size)
../deps/icu-small/source/i18n/calendar.cpp:832:9: note: in expansion of macro 'uprv_strncpy'
832 | uprv_strncpy(actualLocale, right.actualLocale, sizeof(actualLocale));
| ^~~~~~~~~~~~
../deps/icu-small/source/i18n/decNumber.cpp: In function 'decNumber* uprv_decNumberLog10_76(decNumber*, const decNumber*, decContext*)':
../deps/icu-small/source/i18n/decNumber.cpp:1528:14: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
1528 | w->lsu[1]=1; w->lsu[0]=0; /* .. */
| ~~~~~~~~~^~
In file included from ../deps/icu-small/source/i18n/decNumber.cpp:184:
../deps/icu-small/source/i18n/decNumber.h:89:19: note: at offset 1 into destination object 'decNumber::lsu' of size 1
89 | decNumberUnit lsu[DECNUMUNITS];
| ^~~
../deps/icu-small/source/i18n/decNumber.cpp:1528:14: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
1528 | w->lsu[1]=1; w->lsu[0]=0; /* .. */
| ~~~~~~~~~^~
../deps/icu-small/source/i18n/decNumber.h:89:19: note: at offset 1 into destination object 'decNumber::lsu' of size 1
89 | decNumberUnit lsu[DECNUMUNITS];
| ^~~
ar crsT /build/node/out/Release/obj.target/deps/openssl/libopenssl.a @/build/node/out/Release/obj.target/deps/openssl/libopenssl.a.ar-file-list
../deps/icu-small/source/i18n/decNumber.cpp: In function 'decNumber* uprv_decNumberSquareRoot_76(decNumber*, const decNumber*, decContext*)':
../deps/icu-small/source/i18n/decNumber.cpp:2974:31: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
2974 | t->lsu[0]=9; t->lsu[1]=5; t->lsu[2]=2;
| ~~~~~~~~~^~
../deps/icu-small/source/i18n/decNumber.h:89:19: note: at offset 1 into destination object 'decNumber::lsu' of size 1
89 | decNumberUnit lsu[DECNUMUNITS];
| ^~~
../deps/icu-small/source/i18n/decNumber.cpp:2974:44: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
2974 | t->lsu[0]=9; t->lsu[1]=5; t->lsu[2]=2;
| ~~~~~~~~~^~
../deps/icu-small/source/i18n/decNumber.h:89:19: note: at offset 2 into destination object 'decNumber::lsu' of size 1
89 | decNumberUnit lsu[DECNUMUNITS];
| ^~~
rm 6aabcf0377d3bf9ea921abc112f49f170db10739.intermediate
make: *** [Makefile:135: node] Error 2
Additional information
No response
Activity
juanarbol commentedon Dec 23, 2024
Cc @nodejs/build
bnoordhuis commentedon Dec 24, 2024
Can you post the full output of a clean build? I think you've omitted the actual error; I only see warnings, not compile errors.
KnisterPeter commentedon Dec 26, 2024
I will early next year
KnisterPeter commentedon Jan 2, 2025
This is a bigger chunk of the logs:
sxa commentedon Jan 2, 2025
FYI I can reproduce this with either GCC 12 or 13 on Ubuntu 24.04. Seems to have been caused by the update to sqlite in #56178 since I can get past the failure if I revert that change.
bnoordhuis commentedon Jan 2, 2025
For posterity:
It's the 'shared_library' test added to node.gyp in commit 5c2f599.
Adding
'toolsets': ['host']would likely work around this particular error but it's not a proper fix (what if you're cross-compiling?)test: update compiled sqlite tests to match other tests
test: update compiled sqlite tests to match other tests
KnisterPeter commentedon Jan 9, 2025
Is the fix already released? It's still broken in 22.13.0 as well as 23.6.0.
test: update compiled sqlite tests to match other tests
KnisterPeter commentedon Jan 22, 2025
It's still broken for v23.6.1 and v22.13.1.
Any chance this will get released?
test: update compiled sqlite tests to match other tests
test: update compiled sqlite tests to match other tests
KnisterPeter commentedon Feb 12, 2025
It's fixed for the 22.x and 23.x streams. Thanks you so much 🥳
test: update compiled sqlite tests to match other tests