Skip to content

TS transforms not working when source file path contains some chars #56296

Closed
Closed
TS transforms not working when source file path contains some chars#56296
Labels
source mapsIssues and PRs related to source map support.test_runnerIssues and PRs related to the test runner subsystem.

Description

@aduh95
aduh95
opened on Dec 17, 2024

Version

main

Platform

N/A

Subsystem

No response

What steps will reproduce the bug?

$ cat test/fixtures/test-runner/matching-patterns/typescript-test.cts                                            
const test = require('node:test');

// 'as string' ensures that type stripping actually occurs
test('this should pass' as string);
$ cp test/fixtures/test-runner/matching-patterns/typescript-test.cts dir%20with\ \$unusual\"chars\?\'åß∂ƒ©∆¬…\`.cts
$ ./node --experimental-transform-types dir%20with\ \$unusual\"chars\?\'åß∂ƒ©∆¬…\`.cts
node:internal/errors:540
      throw error;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "payload" argument must be of type object. Received null
    at cloneSourceMapV3 (node:internal/source_map/source_map:365:3)
    at new SourceMap (node:internal/source_map/source_map:145:21)
    at findSourceMap (node:internal/source_map/source_map_cache:348:17)
    at lazyFindSourceMap (node:internal/test_runner/test:98:10)
    at new Test (node:internal/test_runner/test:556:21)
    at createTestTree (node:internal/test_runner/harness:82:16)
    at lazyBootstrapRoot (node:internal/test_runner/harness:264:5)
    at run (node:internal/test_runner/harness:302:61)
    at test (node:internal/test_runner/harness:317:12)
    at Object.<anonymous> (…/dir%20with $unusual"chars?'åß∂ƒ©∆¬…`.cts:3:1) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v24.0.0-pre

How often does it reproduce? Is there a required condition?

Required condition: source file path contains some special chars (not sure which)

What is the expected behavior? Why is that the expected behavior?

It should not throw

What do you see instead?

TypeError [ERR_INVALID_ARG_TYPE]: The "payload" argument must be of type object. Received null
    at cloneSourceMapV3 (node:internal/source_map/source_map:365:3)
    at new SourceMap (node:internal/source_map/source_map:145:21)
    at findSourceMap (node:internal/source_map/source_map_cache:348:17)
    at lazyFindSourceMap (node:internal/test_runner/test:98:10)
    at new Test (node:internal/test_runner/test:556:21)
    at createTestTree (node:internal/test_runner/harness:82:16)
    at lazyBootstrapRoot (node:internal/test_runner/harness:264:5)
    at run (node:internal/test_runner/harness:302:61)
    at test (node:internal/test_runner/harness:317:12)
    at Object.<anonymous> (…/dir%20with $unusual"chars?'åß∂ƒ©∆¬…`.cts:3:1) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Additional information

No response

Activity

  1. marco-ippolito commented on Dec 17, 2024

    @marco-ippolito
    marco-ippolito
    on Dec 17, 2024
    Member

    Cc @legendecas

  2. legendecas
    added
    source mapsIssues and PRs related to source map support.
    on Dec 17, 2024

  3. legendecas commented on Dec 18, 2024

    @legendecas
    legendecas
    on Dec 18, 2024
    Member

    FWIW, this is not related to this forged path. This is due to the source map generated with --experimental-tranform-types is invalid, like //# sourceMappingURL=data:application/json;base64,-1. Anyway, this should not crash the test runner.

    #56299 should fix this.

  4. legendecas
    added
    test_runnerIssues and PRs related to the test runner subsystem.
    on Dec 18, 2024

  5. aduh95 commented on Dec 18, 2024

    @aduh95
    aduh95
    on Dec 18, 2024
    ContributorAuthor

    I've tried pulling #56299 into #48409, there's still an issue with e.g. test/fixtures/typescript/ts/test-get-callsite.ts, where the ability to generate a correct source map is dependent on the presence of some chars in the path.

    $ ./node --experimental-transform-types test/fixtures/typescript/ts/test-get-callsite.ts
getCallSite:  [Object: null prototype] {
  functionName: '',
  scriptName: 'file://…/test/fixtures/typescript/ts/test-get-callsite.ts',
  lineNumber: 8,
  column: 18
}
(node:32692) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
$ cp test/fixtures/typescript/ts/test-get-callsite.ts dir%20with\ \$unusual\"chars\?\'åß∂ƒ©∆¬…\`.cts
$ ./node --experimental-transform-types dir%20with\ \$unusual\"chars\?\'åß∂ƒ©∆¬…\`.cts  
getCallSite:  [Object: null prototype] {
  functionName: '',
  scriptName: '…/dir%20with $unusual"chars?\'åß∂ƒ©∆¬…`.cts',
  lineNumber: 2,
  column: 18
}
(node:32814) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

    Notice the reported lineNumber is not the same, indicating I think the source map is not being generated correctly.

  6. legendecas commented on Dec 19, 2024

    @legendecas
    legendecas
    on Dec 19, 2024
    Member

    This sounds like a separate issue from the original crash issue. Submitted #56315 to fix the generation of the invalid source map url.

  7. nodejs-github-bot
    added a commit that references this issue on Dec 21, 2024

    module: use buffer.toString base64

    4fd5db4
  8. legendecas
    closed this as completedon Dec 21, 2024
  9. aduh95
    added 3 commits that reference this issue on Jan 2, 2025

    lib: suppress source map lookup exceptions

    d1b009b

    lib: optimize `prepareStackTrace` on builtin frames

    e4b795e

    module: use buffer.toString base64

    717cfa4
  10. aduh95
    added 3 commits that reference this issue on Jan 31, 2025

    lib: suppress source map lookup exceptions

    df06524

    lib: optimize `prepareStackTrace` on builtin frames

    dc00321

    module: use buffer.toString base64

    acba5dc
  11. marco-ippolito
    added 4 commits that reference this issue on Sep 2, 2025

    lib: suppress source map lookup exceptions

    99b5a52

    lib: optimize `prepareStackTrace` on builtin frames

    78f1233

    lib: suppress source map lookup exceptions

    cdf9850

    lib: optimize `prepareStackTrace` on builtin frames

    2f333b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    source mapsIssues and PRs related to source map support.test_runnerIssues and PRs related to the test runner subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions