Skip to content

parallel/test-abortsignal-drop-settled-signals is flaky #56190

Closed
#56197
Closed
parallel/test-abortsignal-drop-settled-signals is flaky#56190
#56197
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.

Description

@jazelly
jazelly
opened on Dec 9, 2024

Test

test-abortsignal-drop-settled-signals

Platform

No response

Console output

duration_ms: 736.616
exitcode: 1
severity: fail
stack: "\u25B6 when there is a long-lived signal\n  \u2714 drops settled dependant\
  \ signals (164.84014ms)\n  \u2714 keeps all active dependant signals (61.703679ms)\n\
  \u2714 when there is a long-lived signal (227.848054ms)\n\u2714 does not prevent\
  \ source signal from being GCed if it is short-lived (78.327808ms)\n\u2716 drops\
  \ settled dependant signals when signal is composite (9.638435ms)\n  AssertionError\
  \ [ERR_ASSERTION]: Expected values to be strictly equal:\n\n  2 !== 0\n\n      at\
  \ assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)\n \
  \     at Immediate._onImmediate (file:///home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:16)\n\
  \      at process.processImmediate (node:internal/timers:511:21) {\n    generatedMessage:\
  \ true,\n    code: 'ERR_ASSERTION',\n    actual: 2,\n    expected: 0,\n    operator:\
  \ 'strictEqual'\n  }\n\n\u2714 drops settled signals even when there are listeners\
  \ (176.35303ms)\n\u2139 tests 5\n\u2139 suites 1\n\u2139 pass 4\n\u2139 fail 1\n\
  \u2139 cancelled 0\n\u2139 skipped 0\n\u2139 todo 0\n\u2139 duration_ms 496.249118\n\
  \n\u2716 failing tests:\n\ntest at test/parallel/test-abortsignal-drop-settled-signals.mjs:134:1\n\
  \u2716 drops settled dependant signals when signal is composite (9.638435ms)\n \
  \ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\n\n  2 !==\
  \ 0\n\n      at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)\n\
  \      at Immediate._onImmediate (file:///home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:16)\n\
  \      at process.processImmediate (node:internal/timers:511:21) {\n    generatedMessage:\
  \ true,\n    code: 'ERR_ASSERTION',\n    actual: 2,\n    expected: 0,\n    operator:\
  \ 'strictEqual'\n  }"

Build links

Additional information

Reliability report: nodejs/reliability#1052

Activity

  1. jazelly
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Dec 9, 2024

  2. geeksilva97 commented on Dec 9, 2024

    @geeksilva97
    geeksilva97
    on Dec 9, 2024
    Contributor

    Might it be my latest changes in this file? I will check it.

    EDIT: It is. It was not like this before. I'm on it.

  3. geeksilva97 commented on Dec 9, 2024

    @geeksilva97
    geeksilva97
    on Dec 9, 2024
    Contributor

    PR is in place @jazelly . Thank you!

  4. nodejs-github-bot
    closed this as completedin #56197on Dec 12, 2024

  5. lpinca commented on Dec 22, 2024

    @lpinca
    lpinca
    on Dec 22, 2024
    Member

    It is still flaky.

      ---
  duration_ms: 2016.13200
  severity: fail
  exitcode: 1
  stack: |-
    ▶ when there is a long-lived signal
      ✔ drops settled dependant signals (396.375133ms)
      ✔ keeps all active dependant signals (295.167313ms)
    ✔ when there is a long-lived signal (695.403171ms)
    ✔ does not prevent source signal from being GCed if it is short-lived (289.882166ms)
    ✖ drops settled dependant signals when signal is composite (13.987205ms)
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      2 !== 0
      
          at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)
          at Immediate._onImmediate (file:///home/iojs/build/workspace/node/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:18)
          at process.processImmediate (node:internal/timers:511:21) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: 2,
        expected: 0,
        operator: 'strictEqual'
      }
    
    ✔ drops settled signals even when there are listeners (535.062786ms)
    ℹ tests 5
    ℹ suites 1
    ℹ pass 4
    ℹ fail 1
    ℹ cancelled 0
    ℹ skipped 0
    ℹ todo 0
    ℹ duration_ms 1552.021299
    
    ✖ failing tests:
    
    test at test/parallel/test-abortsignal-drop-settled-signals.mjs:135:1
    ✖ drops settled dependant signals when signal is composite (13.987205ms)
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      2 !== 0
      
          at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)
          at Immediate._onImmediate (file:///home/iojs/build/workspace/node/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:18)
          at process.processImmediate (node:internal/timers:511:21) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: 2,
        expected: 0,
        operator: 'strictEqual'
      }
  ...
  6. lpinca
    reopened this on Dec 22, 2024

  7. geeksilva97 commented on Dec 22, 2024

    @geeksilva97
    geeksilva97
    on Dec 22, 2024
    Contributor

    It is still flaky.

      ---
  duration_ms: 2016.13200
  severity: fail
  exitcode: 1
  stack: |-
    ▶ when there is a long-lived signal
      ✔ drops settled dependant signals (396.375133ms)
      ✔ keeps all active dependant signals (295.167313ms)
    ✔ when there is a long-lived signal (695.403171ms)
    ✔ does not prevent source signal from being GCed if it is short-lived (289.882166ms)
    ✖ drops settled dependant signals when signal is composite (13.987205ms)
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      2 !== 0
      
          at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)
          at Immediate._onImmediate (file:///home/iojs/build/workspace/node/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:18)
          at process.processImmediate (node:internal/timers:511:21) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: 2,
        expected: 0,
        operator: 'strictEqual'
      }
    
    ✔ drops settled signals even when there are listeners (535.062786ms)
    ℹ tests 5
    ℹ suites 1
    ℹ pass 4
    ℹ fail 1
    ℹ cancelled 0
    ℹ skipped 0
    ℹ todo 0
    ℹ duration_ms 1552.021299
    
    ✖ failing tests:
    
    test at test/parallel/test-abortsignal-drop-settled-signals.mjs:135:1
    ✖ drops settled dependant signals when signal is composite (13.987205ms)
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      2 !== 0
      
          at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)
          at Immediate._onImmediate (file:///home/iojs/build/workspace/node/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:18)
          at process.processImmediate (node:internal/timers:511:21) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: 2,
        expected: 0,
        operator: 'strictEqual'
      }
  ...

    Omg. I think we have to add gcUntil to this test too.

  8. geeksilva97 commented on Dec 22, 2024

    @geeksilva97
    geeksilva97
    on Dec 22, 2024
    Contributor

    #56339

  9. lpinca
    closed this as completedon Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions