Skip to content

build: make errors that occur in coverage-clean case and coverage-test in Makefile #55288

Closed
#55287
Closed
build: make errors that occur in coverage-clean case and coverage-test in Makefile#55288
#55287

Description

@kmk324
kmk324
opened on Oct 5, 2024

Version

main

Platform

Linux DESKTOP-1B79QEG 5.10.16.3-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

build

What steps will reproduce the bug?

$ make coverage-clean

or

$ make coverage-test

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

No make error occurs

$ make coverage-clean
rm -f -r node_modules
rm -f -r gcovr
rm -f -r coverage/tmp

What do you see instead?

$ make coverage-clean
rm -f -r node_modules
rm -f -r gcovr
rm -f -r coverage/tmp
find: missing argument to '-exec'
make: *** [Makefile:244: coverage-clean] Error 1

Additional information

find's -exec option must end with a semicolon,
but in the previous code, depending on the shell, the semicolon was passed to the find command or was passed as the shell's command separator.
With this change, it will work normally in all shell types.

I attached a PR that works normally in my environment. #55287

Activity

  1. avivkeller commented on Oct 5, 2024

    @avivkeller
    avivkeller
    on Oct 5, 2024
    Member

    I can't reproduce the issue. Are you commands up-to-date?

    $ find --version
find (GNU findutils) 4.10.0
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Eric B. Decker, James Youngman, and Kevin Dalley.
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS(FTS_CWDFD) CBO(level=1) 

    $ make --version                                                                                                   
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

    $ rm --version   
rm (GNU coreutils) 9.4
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Paul Rubin, David MacKenzie, Richard M. Stallman,
and Jim Meyering.

  2. kmk324 commented on Oct 6, 2024

    @kmk324
    kmk324
    on Oct 6, 2024
    ContributorAuthor

    My environment is below

    $ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.5 LTS
Release:        22.04
Codename:       jammy

    $ find --version
find (GNU findutils) 4.8.0
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Eric B. Decker, James Youngman, and Kevin Dalley.
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS(FTS_CWDFD) CBO(level=2)

    $ make --version
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

    $ rm --version
rm (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Paul Rubin, David MacKenzie, Richard M. Stallman,
and Jim Meyering.

    $ sudo apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

    I will check after commands update

  3. kmk324 commented on Oct 6, 2024

    @kmk324
    kmk324
    on Oct 6, 2024
    ContributorAuthor

    On Ubuntu 22.04, the latest version of the find command that doesn't touch core package dependencies seems to be 4.9
    In this 4.9version's find command reproduced the issue.

    $ sudo apt install ./findutils_4.10.0-3_amd64.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'findutils' instead of './findutils_4.10.0-3_amd64.deb'
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 findutils : PreDepends: libc6 (>= 2.38) but 2.35-0ubuntu3.8 is to be installed
E: Unable to correct problems, you have held broken packages.

    $ sudo apt install ./libc6_2.38-1ubuntu6_amd64.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'libc6' instead of './libc6_2.38-1ubuntu6_amd64.deb'
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libc-bin : Depends: libc6 (< 2.36) but 2.38-1ubuntu6 is to be installed
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.

    $ find --version
find (GNU findutils) 4.9.0
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Eric B. Decker, James Youngman, and Kevin Dalley.
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS(FTS_CWDFD) CBO(level=2)

    $ make coverage-clean
rm -f -r node_modules
rm -f -r gcovr
rm -f -r coverage/tmp
find: missing argument to `-exec'
make: *** [Makefile:244: coverage-clean] Error 1
  4. kmk324
    closed this as completedon Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions