{aborted: false} is treated as valid AbortSignal but not in other runtimes #54962

Activity

1. avivkeller

   added

   abortcontrollerIssues and PRs related to the AbortController and AbortSignal APIs.Issues and PRs related to the AbortController and AbortSignal APIs.

   web-standardsIssues and PRs related to web-platform APIs and standards compliance.Issues and PRs related to web-platform APIs and standards compliance.

   on Sep 16, 2024
2. avivkeller commented on Sep 16, 2024

   

   avivkeller

   on Sep 16, 2024

   Last edited by avivkeller

   Member

   More actions

   Spec: https://dom.spec.whatwg.org/#create-a-dependent-abort-signal
3. avivkeller commented on Sep 16, 2024

   

   avivkeller

   on Sep 16, 2024

   Member

   More actions

   Can you provide the exact error given by other runtimes?
4. xwan99 commented on Sep 16, 2024

   

   xwan99

   on Sep 16, 2024

   Author

   More actions

   In Firefox:

   >> AbortSignal.any([ { aborted: false }])
   Uncaught TypeError: AbortSignal.any: Element of argument 1 does not implement interface AbortSignal.
       <anonymous> debugger eval code:1
   

   In Chrome:

   > AbortSignal.any([ { aborted: false }])
   
   VM176:1 Uncaught TypeError: Failed to execute 'any' on 'AbortSignal': Failed to convert value to 'AbortSignal'.
       at <anonymous>:1:13
   

   👍React with 👍1Reacted by Aviv Keller
5. benjamingr commented on Sep 19, 2024

   

   benjamingr

   on Sep 19, 2024

   Member

   More actions

   This was a deliberate design choice (to not brand check) in order to have better ecosystem compatibility.

   Now that we've had AbortSignal for a few years it's fine to revisit

   👍React with 👍1Reacted by Bonnie Wang
6. nodejs-github-bot

   closed this as completedin a5a946don Sep 29, 2024
7. nodejs-github-bot

   added a commit that references this issue on Sep 29, 2024

   lib: validate signals with interface converter

   ...

   e973c3e
8. Clownsw

   added a commit that references this issue on Sep 29, 2024

   lib: implement interface converter in webidl

   ...

   a5a946d