Repository navigation
test_runner: latest.js file is included by default #54726
Description
Version
v22.7.0
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
- Create an empty
latest.jsfile - Run the Node.js test runner
fnm use 20
# Using Node v20.17.0
node --test
# ℹ tests 0
# ℹ suites 0
# ℹ pass 0
# ℹ fail 0
# ℹ cancelled 0
# ℹ skipped 0
# ℹ todo 0
# ℹ duration_ms 4.365042fnm use 22
# Using Node v22.7.0
node --test
# ✔ latest.js (43.960958ms)
# ℹ tests 1
# ℹ suites 0
# ℹ pass 1
# ℹ fail 0
# ℹ cancelled 0
# ℹ skipped 0
# ℹ todo 0
# ℹ duration_ms 53.687041How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
By default, Node.js will run all files matching these patterns:
**/*.test.?(c|m)js
**/*-test.?(c|m)js
**/*_test.?(c|m)js
**/test-*.?(c|m)js
**/test.?(c|m)js
**/test/**/*.?(c|m)js
https://nodejs.org/api/test.html#running-tests-from-the-command-line
What do you see instead?
latest.js filename does not match the above patterns, but is included in node --test
Additional information
No response
Activity
pmarchini commentedon Sep 3, 2024
Hey @hyunbinseo , I believe this issue is caused by the following regex matching pattern: https://github.com/nodejs/node/blob/main/lib/internal/test_runner/utils.js#L54 ->
*[.-_]testI've created a repro and proposed a possible solution in this pull request: #54728.
test_runner: update kPatterns