Skip to content

Adding TCP_FASTOPEN_CONNECT prevents compiling on older systems #54604

Closed as not planned
Closed as not planned
Adding TCP_FASTOPEN_CONNECT prevents compiling on older systems#54604
Labels
caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

Description

@abcbarryn
abcbarryn
opened on Aug 28, 2024

Version

v22.7.0

Platform

Linux static1 3.19.4-1.g51ddeac-desktop #1 SMP PREEMPT Mon Apr 13 13:20:55 UTC 2015 (51ddeac) x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Attempt to compile nodejs on an older system that lacks support for TCP_FASTOPEN_CONNECT.

How often does it reproduce? Is there a required condition?

All the time.

What is the expected behavior? Why is that the expected behavior?

Be able to compile/build nodejs from source.

What do you see instead?

error: ‘TCP_FASTOPEN_CONNECT’ undeclared (first use in this function)

Multiple instances of this

Additional information

Please implement an option to disable this feature if the target platform does not support it.

Also, read this: https://blog.apnic.net/2021/07/05/tcp-fast-open-not-so-fast/

Activity

  1. abcbarryn commented on Aug 28, 2024

    @abcbarryn
    abcbarryn
    on Aug 28, 2024
    Author

    In the mean time, if someone can tell me what the latest version of nodejs is that does not need TCP_FASTOPEN_CONNECT so I can build that?

  2. climba03003 commented on Aug 28, 2024

    @climba03003
    climba03003
    on Aug 28, 2024
    Contributor

    TCP_FASTOPEN_CONNECT is introduced in c-ares@1.33.0 which landed in 22.7.0.

    c-ares@1.33.1 which fixed TCP_FASTOPEN_CONNECT on unsupported platform which landed in yesterday at main.

    In the mean time, if someone can tell me what the latest version of nodejs is that does not need TCP_FASTOPEN_CONNECT so I can build that?

    I believe the previous version 22.6.0 should be fine to use.

  3. abcbarryn commented on Aug 28, 2024

    @abcbarryn
    abcbarryn
    on Aug 28, 2024 via email · Hidden as off-topic
    Author

  4. abcbarryn commented on Aug 28, 2024

    @abcbarryn
    abcbarryn
    on Aug 28, 2024 via email
    Author

  5. abcbarryn commented on Aug 28, 2024

    @abcbarryn
    abcbarryn
    on Aug 28, 2024
    Author

    I will try 22.6.0 and wait for a new release with this fixed.

    PS: Someone needs to delete/disable PiaoR's account. It looks like his message was deleted, but he tried to send me a link to a virus.

  6. avivkeller
    added
    caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.
    on Aug 28, 2024

  7. avivkeller commented on Aug 28, 2024

    @avivkeller
    avivkeller
    on Aug 28, 2024
    Member

    I will try 22.6.0 and wait for a new release with this fixed.

    Should this issue be closed?

  8. abcbarryn commented on Aug 28, 2024

    @abcbarryn
    abcbarryn
    on Aug 28, 2024
    Author

    I have not tested the patch, I am just going to fall back to 22.6.0.

  9. github-actions commented on Apr 28, 2026

    @github-actions
    github-actionsBot
    on Apr 28, 2026 – with GitHub Actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  10. github-actions
    added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Apr 28, 2026

  11. abcbarryn commented on Apr 28, 2026

    @abcbarryn
    abcbarryn
    on Apr 28, 2026
    Author

    I no longer have or use the system on which I encountered this issue so I am unable to test...

  12. github-actions
    removed
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Apr 29, 2026

  13. github-actions commented on Jul 28, 2026

    @github-actions
    github-actionsBot
    on Jul 28, 2026 – with GitHub Actions
    Contributor

    This issue has been marked as stale due to 90 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  14. github-actions
    added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jul 28, 2026
  15. avivkeller
    closed this as not plannedon Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions