Repository navigation
test_runner: do not read from process.argv and process.cwd() in run() #53867
Description
Currently the codebase for
node/lib/internal/test_runner/runner.js
Line 472 in 362afa5
process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in node/lib/internal/main/test_runner.js
Line 68 in 362afa5
run() as options.
Activity
[-]test_runner: do not read from `process.argv` in run()[/-][+]test_runner: do not read from `process.argv` and `process.cwd()` in run()[/+]eliphazbouye commentedon Jul 18, 2024
@mcollina this issue still relevant or are you already working on it ? I ask it because I see you mentioned it on your last PR !
If it's still relevant, I'll start working on it :)
mcollina commentedon Jul 18, 2024
It's likely best to wait until my PR lands first!
eliphazbouye commentedon Jul 18, 2024
Okay, I'll wait :)
test_runner: refactor coverage to pass in config options
mcollina commentedon Jul 25, 2024
@eliphazb go ahead and make the PR!
eliphazbouye commentedon Jul 25, 2024
Okay 🚀 I'm going
test_runner: refactor coverage to pass in config options
eliphazbouye commentedon Aug 2, 2024
@mcollina someone already take it :(
test_runner: refactor coverage to pass in config options
mcollina commentedon Aug 12, 2024
@SophonieBouye doesn't look like it to me. There is a lot more to be done here.
14 remaining items
karankraina commentedon Oct 12, 2024
@cjihrig Can you please elaborate a little on what is pending in this? I will pick it up.
zhanglinqian commentedon Feb 12, 2026
I'd like to work on this issue.
murataslan1 commentedon Mar 21, 2026
Hey, I'd like to take a stab at this.
PR #54705 added
cwdbut there are still a bunch ofprocessreads left inrun():getRunArgs()readsprocess.execArgvandprocess.argvdirectlyrun()falls back toprocess.envwhenopts.envisn't providedprocess.env.NODE_TEST_CONTEXTis checked directlyPlan is to capture these in the CLI entry point and pass them through as options, keeping backwards compat for public API users.
test_runner: avoid reading process state directly in run()
test: pass processExecArgv to run() instead of reading process.execAr…
test: add tests for processExecArgv option in run()
RounakKumarAgarwal commentedon Aug 12, 2026
Hi I would like to work on the issue @mcollina ,can you assign it to me ?
Mohammad-Ranjbar commentedon Sep 1, 2026
Hi, I'd like to work on this issue.
I see that there have been previous linked attempts, but GitHub currently shows no active pull request. Before starting, I'd like to confirm that the proposed direction is still current:
process.argv/process.cwd()-derived values inlib/internal/main/test_runner.js;run()options;lib/internal/test_runner/runner.js;Is this issue still available, and are there any lessons from the previous PRs that I should account for?