Skip to content

AttachCppHeap and DetachCppHeap are deprecated in V8 #52999

Closed as not planned
Closed as not planned

Description

@targos
../../src/env.cc:569:14: warning: 'AttachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate->AttachCppHeap(cpp_heap_.get());
             ^
../../deps/v8/include/v8-isolate.h:1047:3: note: 'AttachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^

../../src/env.cc:600:15: warning: 'DetachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate_->DetachCppHeap();
              ^
../../deps/v8/include/v8-isolate.h:1056:3: note: 'DetachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^

Activity

  1. added
    v8 engineIssues and PRs related to the V8 dependency.
    on May 15, 2024
  2. juanarbol commented on May 19, 2024

    @juanarbol
    Member

    I can work on this one :)

  3. self-assigned this
    on May 19, 2024
  4. targos commented on May 19, 2024

    @targos
    MemberAuthor

    @juanarbol Sorry this is actually a duplicate of #52718. I forgot that I moved that issue.
    #53038 is fixing it.

  5. added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

duplicateIssues and PRs that are duplicates of other issues or PRs.v8 engineIssues and PRs related to the V8 dependency.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions