Repository navigation
[22 regression] Infinite recursion when setting stat.atime #52705
Description
Version
v22.0.0
Platform
Linux
Subsystem
fs
What steps will reproduce the bug?
var fs = requre("fs");
var stat = fs.statSync("./package.json")
stat.atime = 2How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
It should work
What do you see instead?
It throws
Uncaught RangeError: Maximum call stack size exceeded
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
at Stats.set [as atime] (node:internal/fs/utils:469:18)
Additional information
- This is probably caused by fs: make stats date fields lazy #50908 (cc @anonrig), since the setters defined in that PR just call themselves recursively
- I found this while investigating NodeJS 22 breaks vinyl-js gulpjs/vinyl-fs#350, which is probably another regression
Activity
targos commentedon Apr 26, 2024
Another potential bug is that the property is now read-only (even after you access it once to trigger the getter).
nicolo-ribaudo commentedon Apr 26, 2024
I'm opening a PR
mojavelinux commentedon Apr 26, 2024
I'm seeing the same issue with mtime as well.
avivkeller commentedon Apr 26, 2024
Yes, the linked PR will fix both