You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test_runner: differentiate describe from it in event:enqueue so we can have a total test count #51235
@MoLow i have gone through the issue and what i came up with the approach of adding the type of event along with emit('enqueue', { test: ${i}, testType });here on each iteration for tests. I can open a PR if you can confirm if this can be a way to solve things here. would appreciate the feedback!! :)
as i am working on the issue i can no longer find the significance of type of test rather we can do a log of no. of completed test out of total test, which we can increment on each completed test here, i find this better. what do you think @icetbr@MoLow ?
I can't tell if that will work. The current events make it impossible to distinguish between a describe and an it. If that will help with a 30 out of 10000 tests situation, I'm fine with that.
There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the
never-staleIssues and PRs exempt from automated stale handling.
label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
Activity
MoLow commentedon Dec 23, 2023
are you interested on opening a PR for this?
icetbr commentedon Dec 23, 2023
Sure! There is already the type in some events, hopefully I just have to use the same logic. Should I proceed?
Medhansh404 commentedon Jan 1, 2024
@MoLow i have gone through the issue and what i came up with the approach of adding the
typeof event along withemit('enqueue', { test:${i}, testType });here on each iteration for tests. I can open a PR if you can confirm if this can be a way to solve things here. would appreciate the feedback!! :)MoLow commentedon Jan 2, 2024
yes ,that makes sense
Medhansh404 commentedon Jan 3, 2024
as i am working on the issue i can no longer find the significance of type of test rather we can do a log of no. of completed test out of total test, which we can increment on each completed test here, i find this better. what do you think @icetbr @MoLow ?
icetbr commentedon Jan 3, 2024
I can't tell if that will work. The current events make it impossible to distinguish between a describe and an it. If that will help with a
30 out of 10000tests situation, I'm fine with that.github-actions commentedon Jul 2, 2024
There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-staleIssues and PRs exempt from automated stale handling.
label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
EddieAbbondanzio commentedon Jul 23, 2024
I'm gonna pick this up since it seems to be stale.