You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Darwin Devins-MacBook-Air-m2-2022.local 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:57 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T8112 arm64
Subsystem
No response
What steps will reproduce the bug?
Set your time zone of your macOS to Aisa/Shanghai with command sudo systemsetup -settimezone Asia/Shanghai
Create a simple script timezone.js that contains the code console.log(new Date().toString().
Run the script with command node timezone.js
This Output would display on the terminal
Mon Nov 06 2023 00:19:33 GMT+0800 (Central Standard Time)
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
The name of time zone in China is China Standard Time instead of Central Standard Time, the exprected output should be: Mon Nov 06 2023 00:19:33 GMT+0800 (China Standard Time)
What do you see instead?
This Output would display on the terminal
Mon Nov 06 2023 00:19:33 GMT+0800 (Central Standard Time)
Cannot reproduce on macOS ventura TZ='Asia/Shanghai' node -p '[new Date().toString(), process.versions.node]'[ 'Mon Nov 06 2023 19:23:49 GMT+0800 (China Standard Time)', '20.2.0' ]
I execute your command, and it also works for me. Have to set the time zone of macOS to 'Asia/Shanghai' with this command: sudo systemsetup -settimezone Asia/Shanghai, this issue would be reproduced
Quick Question for those who know how ICU updates work: Will this end up being backported to current LTS? We are holding off upgrading to 20.x as the majority of our dev team is now on Sonoma. I assume 74.1 won't end up in LTS, but could a patch to 73 go in?
Quick Question for those who know how ICU updates work: Will this end up being backported to current LTS? We are holding off upgrading to 20.x as the majority of our dev team is now on Sonoma. I assume 74.1 won't end up in LTS, but could a patch to 73 go in?
I'm not sure let me ask about a dot release or patch. I've asked if there's a patch against 73.
Does anyone know whether 74 could land in LTS or not? Landing 74 would be easier.
Activity
kylo5aby commentedon Nov 5, 2023
I have tested on my PC, which time zone is
(UTC +08:00) Beijing, Chongqing, Hongkongon node 20.9.0, but didn't reproduce your issue, also tried bytniessen commentedon Nov 5, 2023
I can't reproduce it in Node.js 20.8.0 on Linux:
richardlau commentedon Nov 5, 2023
May be related to #50301 which is macOS specific.
marco-ippolito commentedon Nov 6, 2023
Cannot reproduce on macOS ventura
TZ='Asia/Shanghai' node -p '[new Date().toString(), process.versions.node]'[ 'Mon Nov 06 2023 19:23:49 GMT+0800 (China Standard Time)', '20.2.0' ]richardlau commentedon Nov 6, 2023
See also https://unicode-org.atlassian.net/browse/ICU-22541. Possibly fixed in ICU 74.1 but #50515 will need work to land.
DevinJohw commentedon Nov 6, 2023
I execute your command, and it also works for me. Have to set the time zone of macOS to 'Asia/Shanghai' with this command:
sudo systemsetup -settimezone Asia/Shanghai, this issue would be reproducedDevinJohw commentedon Nov 6, 2023
It's good, should I close this issue?
bnoordhuis commentedon Nov 11, 2023
I'll go ahead and close this. Summary: upstream bug fixed in newer versions. Upgrade pending.
srl295 commentedon Nov 14, 2023
Any work besides the unit test failures? FyI @sven-oly
DavidDudson commentedon Dec 1, 2023
Quick Question for those who know how ICU updates work: Will this end up being backported to current LTS? We are holding off upgrading to 20.x as the majority of our dev team is now on Sonoma. I assume 74.1 won't end up in LTS, but could a patch to 73 go in?
srl295 commentedon Dec 1, 2023
I'm not sure let me ask about a dot release or patch. I've asked if there's a patch against 73.
Does anyone know whether 74 could land in LTS or not? Landing 74 would be easier.