Repository navigation
Add a GHA Windows test workflow? #50489
Description
When pull requests are opened/updated in this repo the following workflows are automatically run:
- https://github.com/nodejs/node/blob/6557c1c9b1206a85bb7d8e7450e8c3a4cff7c84b/.github/workflows/test-linux.yml
- https://github.com/nodejs/node/blob/6557c1c9b1206a85bb7d8e7450e8c3a4cff7c84b/.github/workflows/test-macos.yml
But there isn't a corresponding Windows workflow. This is causing a bit of headache for at least me in PR #48740. I don't have a Windows system to test on, but the PR needs to pass on Windows. The only way to get the PR to get run against a Windows system is for someone with privileges to add the needs-ci tag to the PR, and then it takes someone familiar with Jenkins, or at least the org's Jenkins setup, to find what the error is.
Given all of that, why isn't there a GitHub Actions workflow that runs the tests on Windows?
Activity
richardlau commentedon Oct 31, 2023
Nobody has volunteered to implement one (i.e. no follow up to #32450 (comment)).
jsumners commentedon Oct 31, 2023
🙁
Is there no one with Windows knowledge on the core team that could add it?
bnoordhuis commentedon Oct 31, 2023
"Vested interest" is probably a better choice of words than "knowledge."
I suspect the vast majority of regular contributors run Linux or macOS, not Windows. If you want to see it happen, send a pull request.
jsumners commentedon Oct 31, 2023
I have zero knowledge of building this thing in Windows. My only interest is in seeing validation on PRs without the overhead outlined above.
H4ad commentedon Nov 1, 2023
I have a Windows machine, I can help with that, I just need some direction on it, if you can add some issues/docs about how is working today, I can start from that, otherwise, I will try dig into the current GHA to see how it works.
Also, do we have resources to run on Windows? I mean, I don't know if we use Runners from Github or if we run on our infrastructure.
richardlau commentedon Nov 1, 2023
@H4ad We have our own infrastructure but that's only used for the Jenkins CI. For anything running on GitHub actions we use the standard runners.
jsumners commentedon Nov 1, 2023
Thank you @H4ad.
targos commentedon Nov 1, 2023
You could start with a copy of https://github.com/nodejs/node/blob/main/.github/workflows/coverage-windows.yml
richardlau commentedon Nov 1, 2023
Also https://github.com/nodejs/node/blob/main/.github/workflows/build-windows.yml. Ideally replace this with a
test-windowsworkflow.H4ad commentedon Nov 2, 2023
Just for education purposes, what makes the CI run except for the
onproperty? I ask this because I thought thecoverage-windowsshould run by default on PRs but is not the case.targos commentedon Nov 2, 2023
coverage-windowsdoesn't run because it is currently disabled: #50049bcoe commentedon Jul 25, 2024
Edit: @targos @richardlau just noting that as of the time of this comment Coverage Windows is disabled manually again:
richardlau commentedon Jul 25, 2024
@bcoe Building on Windows with the latest Visual Studio (i.e. the one in the GitHub Action runners) is broken due to a compiler bug.
Refs: nodejs/build#3739
Refs: #53863
StefanStojanovic commentedon Dec 19, 2024
There was another problem with VS 17.12, but it is resolved now. From what I see Windows GH action is running again now, so I'll close this issue.
XANXAY2255 commentedon Feb 18, 2025