Repository navigation
process.versions.zlib does not include the commit hash #50139
Description
Despite upgrade to the bundled zlib library in #50085 the process.versions.zlib output remains the same.
node -p 'process.versions.zlib'
1.2.13.1-motley
node -v
v18.18.1
./node -p 'process.versions.zlib'
1.2.13.1-motley
./node -v
v21.0.0-pre
The expected output of process.versions.zlib would be e.g. 1.2.13.1-motley-f5fd0ad, that is including the commit hash from upstream.
Activity
MrJithil commentedon Oct 11, 2023
Seems like
ZLIB_VERSIONnot updated in thezlib.hheader file. I can see same version info after running thetools/dep_updaters/update-zlib.shMrJithil commentedon Oct 11, 2023
The version info we are using https://chromium.googlesource.com/chromium/src/third_party/zlib.git/+/refs/heads/main/zlib.h#40 from here. Which is
1.2.13.1-motleySo, seems its working as designed.
panva commentedon Oct 11, 2023
It's clearly insufficient given the updates don't change this constant. It should include the current hash.
MrJithil commentedon Oct 11, 2023
Okay. Could you please suggest which variable should map here? Or do we need to take the latest commit hash shorthand?
panva commentedon Oct 11, 2023
@MrJithil
node/tools/dep_updaters/update-zlib.sh
Line 82 in ed49722
MrJithil commentedon Oct 11, 2023
Got it.
Please suggest the approach.
To accomodate the commit shorthand, we need to create a new header file inside the
deps/zlibwith a new definition,ZLIB_VERSIONor some suitable names.Then inside the
src/node_metadata.cc, we can import the new definition.Is this is fine?
src: add commit hash shorthand in zlib version
src: add commit hash shorthand in zlib version
src: add commit hash shorthand in zlib version